Merge pull request #48 from astro-informatics/mdavezac/issue45

Incorrect rotation

Author: mdavezac

.github/workflows/conan.yml

@@ -34,7 +34,7 @@ jobs:
       - name: create stable package
         shell: bash
         run: |
-          if [ "${{ github.ref }}" = "refs/tags/v1.3.4" ]; then
+          if [ "${{ github.ref }}" = "refs/tags/v1.3.5" ]; then
             channel="stable"
           else
             channel="testing"
@@ -54,4 +54,4 @@ jobs:
 
         run: |
           conan remote add astro-informatics ${CONAN_REMOTE_URL}
-          conan upload ssht/1.3.4 -c --all -r=astro-informatics
+          conan upload ssht/1.3.5 -c --all -r=astro-informatics

.github/workflows/python.yml

@@ -119,14 +119,14 @@ jobs:
             mv source-distribution/*.tar.gz  wheel-*/*.whl dist
 
       - name: Publish distribution 📦 to Test PyPI
-        if: ${{ github.ref != 'refs/tags/v1.3.4' }}
+        if: ${{ github.ref != 'refs/tags/v1.3.5' }}
         uses: pypa/gh-action-pypi-publish@master
         with:
           password: ${{ secrets.TEST_PYPI_TOKEN }}
           repository_url: https://test.pypi.org/legacy/
 
       - name: Publish distribution 📦 to PyPI
-        if: ${{ github.ref == 'refs/tags/v1.3.4' }}
+        if: ${{ github.ref == 'refs/tags/v1.3.5' }}
         uses: pypa/gh-action-pypi-publish@master
         with:
           password: ${{ secrets.PYPI_TOKEN }}

CMakeLists.txt

@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.12)
 
 project(
   Ssht
-  VERSION "1.3.4"
+  VERSION "1.3.5"
   DESCRIPTION "Fast and exact spin spherical harmonic transforms"
   HOMEPAGE_URL "http://astro-informatics.github.io/ssht/"
   LANGUAGES C)

README.md

@@ -3,7 +3,7 @@
 [docs-img]: https://img.shields.io/badge/docs-stable-blue.svg
 [docs-url]: https://astro-informatics.github.io/ssht/
 [bintray-img]: https://img.shields.io/bintray/v/astro-informatics/astro-informatics/ssht:astro-informatics?label=C%20package
-[bintray-url]: https://bintray.com/astro-informatics/astro-informatics/ssht:astro-informatics/1.3.4:stable/link
+[bintray-url]: https://bintray.com/astro-informatics/astro-informatics/ssht:astro-informatics/1.3.5:stable/link
 [pypi-img]: https://badge.fury.io/py/pyssht.svg
 [pypi-url]: https://badge.fury.io/py/pyssht
 [codefactor-img]: https://www.codefactor.io/repository/github/astro-informatics/ssht/badge/main

conanfile.py

@@ -3,7 +3,7 @@
 
 class SshtConan(ConanFile):
     name = "ssht"
-    version = "1.3.4"
+    version = "1.3.5"
     license = "GPL-3.0"
     url = "https://github.com/astro-informatics/ssht"
     homepage = "https://github.com/astro-informatics/ssht"

makefile

@@ -1,7 +1,7 @@
 # ======== COMPILER ========
 
 CC      = gcc
-OPT		= -std=c99 -pedantic -Wall -O3 -fopenmp -DSSHT_VERSION=\"1.3.4\" -DSSHT_BUILD=\"`git rev-parse HEAD`\"
+OPT		= -std=c99 -pedantic -Wall -O3 -fopenmp -DSSHT_VERSION=\"1.3.5\" -DSSHT_BUILD=\"`git rev-parse HEAD`\"
 #OPT	= -Wall -g -fopenmp -DSSHT_VERSION=\"1.0b1\" -DSSHT_BUILD=\"`git rev-parse HEAD`\"
 
 

setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 1.3.4
+current_version = 1.3.5
 commit = False
 tag = False
 parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(rc(?P<rc>\d+))?

setup.py

@@ -26,7 +26,7 @@
 
 setup(
     name="pyssht",
-    version="1.3.4",
+    version="1.3.5",
     author=[
         "J. D. McEwen",
         "C. R. G. Wallis",

src/pyssht/pyssht.pyx

@@ -1086,12 +1086,10 @@ def rotate_image(image, rot_list, Method=None):
   phi = (j_array)*2*np.pi/Width
 
   # convert theta phi to x, y, z
-
   x, y, z = s2_to_cart(theta, phi)
 
   # rotate x, y, z
-
-  x, y, z = rot_cart_2d(x, y, z, rot_list)
+  x, y, z = rot_cart_2d(-x, -y, -z, rot_list)
 
   # convert x, y, z, to theta, phi
   theta, phi = cart_to_s2(x, y, z)