Skip to content

Compilation under openSUSE Tumbleweed #5

@rmathar

Description

@rmathar

There is at least one mandatory patch to compile skymaker-4.3.0
on openSUSE Tumbleweed:

  • correct the static double gammln() to static double gammln(double xx)
    near line 49 of src/random.c .
    The default C-compiler does not like to see the same function
    announced with two different signatures.

Because the default configure mode is "with cfitsio", one needs
to add BuildRequires: cfitsio-devel in skymaker.spec

I'd also strongly recommend to change the str[88]
to str[MAXCHAR] in line 163 of imaout.c to avoid buffer
overflow with the strncpy later in the function.

The files in the wcs subdirectory have the same problem of using
old K&R style of coding as in astromatic/sextractor#77
It seems (?) one can just copy the files from the current
https://github.com/astromatic/sextractor/tree/master/src/wcs
over here to patch this, because the files are apparently just copies
of the old files of sextractor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions