We must not update the coordinates (ra/dec) of a catalog in place. That is an "illegal" action that breaks the HATS partitioning structure (e.g. _healpix_29, as well as margins, which we need for most spatial operations to be accurate). We should probably have a safeguard in methods that wrap user-defined functions (map_partitions, map_rows, merge_map), to prevent the users from making this mistake.
Motivation: Please see dp2_gaia_epoch_propagation.ipynb (section 5). If we had updated the Gaia coordinates in place instead of creating two new columns ("ra_corr", "dec_corr"), no errors would have been raised.
We must not update the coordinates (ra/dec) of a catalog in place. That is an "illegal" action that breaks the HATS partitioning structure (e.g.
_healpix_29, as well as margins, which we need for most spatial operations to be accurate). We should probably have a safeguard in methods that wrap user-defined functions (map_partitions,map_rows,merge_map), to prevent the users from making this mistake.Motivation: Please see dp2_gaia_epoch_propagation.ipynb (section 5). If we had updated the Gaia coordinates in place instead of creating two new columns ("ra_corr", "dec_corr"), no errors would have been raised.