Skip to content

Proposal: A shared trait for tls acceptors that are implemented by both async-tls and async-native-tls #43

Open
@jbr

Description

@jbr

I have some code that implements this using wrapper types, but would really love for a trait like this to exist:

A proposed async-tls-acceptor crate that publishes this trait:

#[async_trait]
pub trait Acceptor<Input>: Clone + Send + Sync + 'static
where
    Input: AsyncRead + AsyncWrite + Send + Sync + Unpin + 'static,
{
    type Output: AsyncRead + AsyncWrite + Send + Sync + Unpin + 'static;
    type Error: std::fmt::Debug + Send + Sync;

    async fn accept(&self, input: Input) -> Result<Self::Output, Self::Error>;
}

The implementation for async-tls would be:

#[async_trait]
impl<Input> Acceptor<Input> for async_tls::TlsAcceptor
where
    Input: AsyncRead + AsyncWrite + Send + Sync + Unpin + 'static,
{
    type Output = async_tls::TlsStream<Input>;
    type Error = std::io::Error;
    async fn accept(&self, input: Input) -> Result<Self::Output, Self::Error> {
        async_tls::TlsAcceptor::accept(&self, input).await
    }
}

Would this be welcomed?

refs: chatmail/async-native-tls#27

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions