-
Notifications
You must be signed in to change notification settings - Fork 87
Description
We need to improve RTM command behavior while CI checks are in progress.
The problem I am facing is that when reviewing a PR, it may look good and you want to merge it, but the branch is not updated. So when you go ahead and update the branch, you have to wait for quite some time until all the checks are finished (the testing workflow takes time). Only after all the tests passes, you can add the RTM command.
If you try adding the RTM command while CI is still running, the bot somehow removes the RTM label, and hence you need to add the RTM command again to merge it. An example of this happening is here: asyncapi/website#4823. The bot removes the RTM label, then you have to wait until all the mandatory checks are complete, and only then should you add the RTM command.
The problem with this is that you have to wait on that PR until the checks are passed, but there is no real point in waiting, as you have already checked that all the CI was passing when the branch was outdated. Updating the branch breaking the CI is highly unlikely, and even if it happens, the bot will simply not be able to merge it.
So, most of the time, you just wait until the checks are passed and then add the RTM command. We should handle this scenario such that if CI is running, it should wait until it is finished.