"Collapse all/Expand all" Bug in Swagger UI

[songyang-dev]

Description

I am reporting an issue observed in Swagger UI (swagger-api/swagger-editor#5697). The maintainer says it stems from asyncapi-react.

The Expand All and Collapse All buttons seem unaware of the section's state. It does not update itself. Here is the site. https://editor.swagger.io/. Go to the Schemas section.

Expected result

The Expand All and Collapse All should be aware of the section's opened or closed state.

Actual result

Steps to reproduce

Go to https://editor.swagger.io/.

Troubleshooting

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[yash-ladda]

I’d be happy to work on this issue. Please assign it to me so I can start working on the fix. Thanks!

[Athaxv]

Hi @songyang-dev,

I tested this and can confirm the issue.

The "Expand all" / "Collapse all" button text does not reflect the actual expanded state of the schema. It currently relies on deepExpand instead of expanded, which causes cases where the button shows "Collapse all" even when the section is collapsed.

The root cause appears to be:
{deepExpand ? 'Collapse all' : 'Expand all'}

Proposed fix:
Update the button text to rely on expanded rather than deepExpand, so it correctly mirrors the schema’s expansion state.

If this sounds good, I’d be happy to take this up.

[songyang-dev]

I am not the maintainer. I can't assign people.

[AceTheCreator]

@catosaurusrex2003 wanna look at this in your current #1121 PR? since you're refactoring the schema i think we should just fix it from there

[catosaurusrex2003]

Cool. Ill fix it.

[catosaurusrex2003]

added the fix in #1121
should be resolved when merged