fix: adding functionality to update isvotedinlast3months in tsc_voting_overview.md#1630
Closed
Shivrajsoni wants to merge 3 commits intoasyncapi:masterfrom
Shivrajsoni:feat
Closed
fix: adding functionality to update isvotedinlast3months in tsc_voting_overview.md#1630Shivrajsoni wants to merge 3 commits intoasyncapi:masterfrom Shivrajsoni:feat
Shivrajsoni wants to merge 3 commits intoasyncapi:masterfrom
Shivrajsoni:feat
Conversation
Shivrajsoni
requested review from
asyncapi-bot-eve,
derberg and
thulieblack
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Shivrajsoni
changed the title
Shivrajsoni
changed the title
derberg
reviewed
Jan 8, 2025
| if (userInfo) { | ||
| voteInfo.isVotedInLast3Months = true; | ||
| voteInfo.lastParticipatedVoteTime = currentTime; | ||
| voteInfo.isVotedInLast3Months = isVotingWithinLastThreeMonths(voteInfo.lastParticipatedVoteTime)? 'true' : 'false'; |
Member
There was a problem hiding this comment.
can you explain how did you try to test it locally? isVotingWithinLastThreeMonths expects an object, and here you don't pass an object?
Author
|
can you provide me resources for testing it locally, i am not able to find out ? |
Member
|
@Shivrajsoni there is no easy solution in place yet. You would need to do some refactoring and enable such functionality to run the script on local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1614
Description
update voting_tracker.js so that at each user Update , isVotedInLast3Months (in table ) get updated according to lastparticipatedvotetime (of table TSC_VOTING_OVERVIEW)
and manually updated the TSC_VOTING_OVERVIEW.md file