-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
would be nice if venue from past events is grayed out #208
Comments
Thank you, Lukasz. I appreciate your input. Here's what I think;
|
sounds good, but I guess it is a separate issue? |
Yes. |
@Mayaleeeee I will mark this issue as /gfi js |
Hey @derberg, your message doesn't follow the requirements, you can try |
/gfi js |
Alright, I will. |
Hey @derberg, I would like to work on this issue. |
go ahead 🙏 |
Hi @derberg , I saw that in the date field there was no particular format follow. I was thinking of using Date module to compare the dates, but found dissimilar date formats. Like in one event there is a range and others have a single date. For example, Should I use regex expression for this or traverse the string to look for range format ? |
hey, not a codeowner here @AceTheCreator please have a look |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Still relevant |
Hey, I would like to work on this issue. May I have is assigned to me ? |
I have made the required changes and added a function, which compares the present date and event date to decide the tag for the event (from Upcoming and Ended). Also fades the text color of past events. This is specific to the current format of date used in the cityList.json file. I have also removed the "apply to be a speaker" button from the past events as it has no use there. Please review the PR and if there is any other changes needed, then please let me know |
I have just left a comment on the PR. Thank you. |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
When you go to conference.asyncapi.com you see
Venues
sectionI think that it would be nice if for past events, given venue is somehow grayed out, or have some water mark like
ended
🤔@Mayaleeeee wdyt? how that should be done? just grayed out?
The text was updated successfully, but these errors were encountered: