Skip to content

Commit 3d03ca0

Browse files
authored
chore: remove Requires.test.js and updated README.md of packages (#1436)
Co-authored-by: Adi-204 <adiboghawala@gmail.com>
1 parent 719d5bc commit 3d03ca0

File tree

3 files changed

+1
-20
lines changed

3 files changed

+1
-20
lines changed

packages/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ This approach with templates developed as part of `generator` repository is a wo
2323
5. Each new template or new feature in existing template must be done with reusability in mind. Custom helpers and components should be limited to minimum.
2424
6. Helpers need dedicated tests. We are yet to agree if we should base these on dummy AsyncAPI documents or just mock fake Parser objects inside tests.
2525
7. Components should also be tested separately, expecially if they are reused across templates.
26-
8. Each template should have a set of snapshot tests that help understand if changes in the PR affect the output of the template.
26+
8. Each template should have a set of snapshot tests that help understand if changes in the PR affect the output of the template. Only template components with conditions require separate testing.
2727
9. Every time new template feature is added it must be consulted with:
2828
- Spec references docs using [raw docs](https://www.asyncapi.com/docs/reference/specification/v3.0.0) or [visualizer](https://www.asyncapi.com/docs/reference/specification/v3.0.0-explorer) .
2929
- [Parser API](https://github.com/asyncapi/parser-api/blob/master/docs/api.md) to use it's capabilities instead of doing workarounds like for example `binding.json()["query"]["properties"]`

packages/templates/clients/js/websocket/test/components/Requires.test.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

packages/templates/clients/js/websocket/test/components/__snapshots__/Requires.test.js.snap

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)