[BUG] :Potential test isolation issue due to shared AsyncAPI Parser instance and parsed document across helper tests

[SHUBHANSHU602]

Describe the bug.

While reviewing the integration tests under packages/helpers/test, I noticed that multiple test suites share a single AsyncAPI Parser instance and a single parsed AsyncAPI document via beforeAll.

Examples include (but are not limited to):

bindings.test.js discriminators.test.js operations.test.js servers.test.js

Current Behavior

Parser is a stateful class.
The parsed AsyncAPI document exposes mutable collections (channels, operations, messages).
Sharing a single parser instance and parsed document across tests can introduce:
State leakage between tests
Order-dependent behavior
Fragility when tests are run in parallel or when new tests are added

There is already an explicit comment in bindings.test.js indicating that shared state must be preserved:

Expected behavior

Each test suite (or test case) should be fully isolated, meaning:

Tests should not depend on shared parser state or shared parsed documents.
Mutations or derived data in one test should not affect other tests.
Test outcomes should be deterministic regardless of execution order or parallelization.

Suggested direction

To improve isolation and long-term stability, it may be preferable to:

Instantiate a new Parser per test suite or per test, and/or
Parse the AsyncAPI document in a more isolated scope instead of sharing it globally via beforeAll.

Screenshots

How to Reproduce

Clone the repo
visit:-generator\packages\helpers\test
Analyse:-
bindings.test.js discriminators.test.js operations.test.js servers.test.js

🖥️ Device Information [optional]

Operating System :-Brave
Browser: Brave

👀 Have you checked for similar open issues?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

[dosubot]

You’re absolutely right—each of the helper test files you mentioned (bindings, discriminators, operations, servers) currently shares a single Parser instance and parsed AsyncAPI document via beforeAll, which can lead to state leakage, order-dependent behavior, and non-deterministic test outcomes. This pattern is confirmed in the code, and aside from a single comment in bindings.test.js about preserving original channel data, there’s no explicit rationale for the shared state approach in these tests. No existing issues or discussions address this specific problem.

Best practice here would be to instantiate a new Parser and parse the AsyncAPI document in a more isolated scope—ideally per test or per describe block—to ensure full test isolation and deterministic results. This matches your suggested direction and aligns with how integration project tests were recently improved for isolation in the repo, though that change didn’t cover these helper tests yet (source).

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[Adi-204]

Thanks for the detailed @SHUBHANSHU602! After reviewing, I don't think this needs a change right now.
The parsed AsyncAPI document is effectively immutable after parsing — none of our tests mutate it at the document level. Where local mutation is needed (e.g. filtering channels), we already guard against it with explicit copies, as seen in createChannelsWithOnly. Moving to per-test parsing would slow down the suite with no practical correctness benefit, since Jest already isolates test files in separate workers. The shared beforeAll pattern is idiomatic Jest and works well here.
I hope it make sense, closing the issue for now!

[SHUBHANSHU602]

@Adi-204 Thanku for explaining this .