Skip to content

fix: add docker-java.properties so that generated test code works with the recent version of Docker#456

Open
sekikn wants to merge 1 commit intoasyncapi:masterfrom
sekikn:fix-testcontainers-problem
Open

fix: add docker-java.properties so that generated test code works with the recent version of Docker#456
sekikn wants to merge 1 commit intoasyncapi:masterfrom
sekikn:fix-testcontainers-problem

Conversation

@sekikn
Copy link

@sekikn sekikn commented Dec 2, 2025 •
edited
Loading

Description

  • This PR adds docker-java.properties which specifies Docker client version explicitly so that the generated code using Testcontainers works with the recent version of Docker (29.0.0+). Upgrading Testcontainers to 2.0.2+ is a straightforward solution, but it introduces incompatible API change and will take some time to address. So this PR uses an alternative workaround. I tested it as follows:
$ npm t -- --runInBand

...

Test Suites: 6 passed, 6 total
Tests:       11 passed, 11 total
Snapshots:   51 passed, 51 total
Time:        4.829 s, estimated 11 s
Ran all test suites.

$ asyncapi generate fromTemplate tests/mocks/kafka.yml . -o /tmp/kafka
┌  AsyncAPI Generator
│
◇  Check out your shiny new generated files at /tmp/kafka.

$ cd /tmp/kafka
$ chmod +x gradlew
$ ./gradlew test --tests com.asyncapi.TestcontainerKafkaTest

...

BUILD SUCCESSFUL in 7s
5 actionable tasks: 1 executed, 4 up-to-date

Related issue(s)

Resolves #455

github-actions[bot]
github-actions bot reviewed Dec 2, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sekikn sekikn mentioned this pull request Dec 5, 2025
Open
@sekikn sekikn force-pushed the fix-testcontainers-problem branch from 49de1d9 to 780ce4f Compare January 30, 2026 06:36
@sekikn sekikn mentioned this pull request Jan 30, 2026
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 14, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
66.7% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Tenischev Tenischev Awaiting requested review from Tenischev Tenischev is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Generated test using Testcontainers doesn't work with the recent version of Docker

1 participant

@sekikn