fix: use this. for property setter in c# class renderer (#1874)

marakalwa · web-flow · commit 6291e042c82e · 2024-03-10T14:59:54.000+01:00
diff --git a/examples/csharp-change-collection-type/__snapshots__/index.spec.ts.snap b/examples/csharp-change-collection-type/__snapshots__/index.spec.ts.snap
@@ -9,7 +9,7 @@ Array [
   public IEnumerable<string>? Email 
   {
     get { return email; }
-    set { email = value; }
+    set { this.email = value; }
   }
 }",
 ]
diff --git a/examples/csharp-generate-equals-and-hashcode/__snapshots__/index.spec.ts.snap b/examples/csharp-generate-equals-and-hashcode/__snapshots__/index.spec.ts.snap
@@ -9,7 +9,7 @@ Array [
   public string? Email 
   {
     get { return email; }
-    set { email = value; }
+    set { this.email = value; }
   }
 
   public override bool Equals(object obj)
diff --git a/examples/csharp-generate-json-serializer/__snapshots__/index.spec.ts.snap b/examples/csharp-generate-json-serializer/__snapshots__/index.spec.ts.snap
@@ -10,7 +10,7 @@ public partial class Root
   public string? Email 
   {
     get { return email; }
-    set { email = value; }
+    set { this.email = value; }
   }
 }
 
diff --git a/examples/csharp-generate-newtonsoft-serializer/__snapshots__/index.spec.ts.snap b/examples/csharp-generate-newtonsoft-serializer/__snapshots__/index.spec.ts.snap
@@ -10,7 +10,7 @@ public partial class Root
   public string? Email 
   {
     get { return email; }
-    set { email = value; }
+    set { this.email = value; }
   }
 }
 
diff --git a/examples/csharp-generate-required-properties/__snapshots__/index.spec.ts.snap b/examples/csharp-generate-required-properties/__snapshots__/index.spec.ts.snap
@@ -12,25 +12,25 @@ Array [
   public bool RequiredBoolean 
   {
     get { return requiredBoolean; }
-    set { requiredBoolean = value; }
+    set { this.requiredBoolean = value; }
   }
 
   public bool? NotRequiredBoolean 
   {
     get { return notRequiredBoolean; }
-    set { notRequiredBoolean = value; }
+    set { this.notRequiredBoolean = value; }
   }
 
   public string RequiredString 
   {
     get { return requiredString; }
-    set { requiredString = value; }
+    set { this.requiredString = value; }
   }
 
   public string? NotRequiredString 
   {
     get { return notRequiredString; }
-    set { notRequiredString = value; }
+    set { this.notRequiredString = value; }
   }
 }",
 ]
diff --git a/examples/csharp-use-inheritance/__snapshots__/index.spec.ts.snap b/examples/csharp-use-inheritance/__snapshots__/index.spec.ts.snap
@@ -9,7 +9,7 @@ Array [
   public string[]? Email 
   {
     get { return email; }
-    set { email = value; }
+    set { this.email = value; }
   }
 }",
 ]
diff --git a/examples/generate-csharp-models/__snapshots__/index.spec.ts.snap b/examples/generate-csharp-models/__snapshots__/index.spec.ts.snap
@@ -12,25 +12,25 @@ Array [
   public string? Email 
   {
     get { return email; }
-    set { email = value; }
+    set { this.email = value; }
   }
 
   public System.DateTime? Today 
   {
     get { return today; }
-    set { today = value; }
+    set { this.today = value; }
   }
 
   public System.TimeSpan? Duration 
   {
     get { return duration; }
-    set { duration = value; }
+    set { this.duration = value; }
   }
 
   public System.Guid? UserId 
   {
     get { return userId; }
-    set { userId = value; }
+    set { this.userId = value; }
   }
 }",
 ]
diff --git a/src/generators/csharp/renderers/ClassRenderer.ts b/src/generators/csharp/renderers/ClassRenderer.ts
@@ -144,6 +144,6 @@ export const CSHARP_DEFAULT_CLASS_PRESET: CsharpClassPreset<CSharpOptions> = {
     if (options?.autoImplementedProperties) {
       return 'set;';
     }
-    return `set { ${property.propertyName} = value; }`;
+    return `set { this.${property.propertyName} = value; }`;
   }
 };
diff --git a/test/generators/csharp/__snapshots__/CSharpGenerator.spec.ts.snap b/test/generators/csharp/__snapshots__/CSharpGenerator.spec.ts.snap
@@ -21,13 +21,13 @@ exports[`CSharpGenerator class renderer should be able to overwrite property pre
   public string? Property 
   {
     get { return property; }
-    set { property = value; }
+    set { this.property = value; }
   }
 
   public Dictionary<string, string>? AdditionalProperties 
   {
     get { return additionalProperties; }
-    set { additionalProperties = value; }
+    set { this.additionalProperties = value; }
   }
 }"
 `;
@@ -48,55 +48,55 @@ exports[`CSharpGenerator should render \`class\` type 1`] = `
   public string StreetName 
   {
     get { return streetName; }
-    set { streetName = value; }
+    set { this.streetName = value; }
   }
 
   public string City 
   {
     get { return city; }
-    set { city = value; }
+    set { this.city = value; }
   }
 
   public string State 
   {
     get { return state; }
-    set { state = value; }
+    set { this.state = value; }
   }
 
   public double HouseNumber 
   {
     get { return houseNumber; }
-    set { houseNumber = value; }
+    set { this.houseNumber = value; }
   }
 
   public bool? Marriage 
   {
     get { return marriage; }
-    set { marriage = value; }
+    set { this.marriage = value; }
   }
 
   public dynamic? Members 
   {
     get { return members; }
-    set { members = value; }
+    set { this.members = value; }
   }
 
   public dynamic[]? TupleType 
   {
     get { return tupleType; }
-    set { tupleType = value; }
+    set { this.tupleType = value; }
   }
 
   public string[] ArrayType 
   {
     get { return arrayType; }
-    set { arrayType = value; }
+    set { this.arrayType = value; }
   }
 
   public Dictionary<string, dynamic>? AdditionalProperties 
   {
     get { return additionalProperties; }
-    set { additionalProperties = value; }
+    set { this.additionalProperties = value; }
   }
 }"
 `;
@@ -218,55 +218,55 @@ exports[`CSharpGenerator should render models and their dependencies 1`] = `
     public string StreetName 
     {
       get { return streetName; }
-      set { streetName = value; }
+      set { this.streetName = value; }
     }
 
     public string City 
     {
       get { return city; }
-      set { city = value; }
+      set { this.city = value; }
     }
 
     public string State 
     {
       get { return state; }
-      set { state = value; }
+      set { this.state = value; }
     }
 
     public double HouseNumber 
     {
       get { return houseNumber; }
-      set { houseNumber = value; }
+      set { this.houseNumber = value; }
     }
 
     public bool? Marriage 
     {
       get { return marriage; }
-      set { marriage = value; }
+      set { this.marriage = value; }
     }
 
     public dynamic? Members 
     {
       get { return members; }
-      set { members = value; }
+      set { this.members = value; }
     }
 
     public dynamic[] ArrayType 
     {
       get { return arrayType; }
-      set { arrayType = value; }
+      set { this.arrayType = value; }
     }
 
     public OtherModel? OtherModel 
     {
       get { return otherModel; }
-      set { otherModel = value; }
+      set { this.otherModel = value; }
     }
 
     public Dictionary<string, dynamic>? AdditionalProperties 
     {
       get { return additionalProperties; }
-      set { additionalProperties = value; }
+      set { this.additionalProperties = value; }
     }
   }
 }"
@@ -285,13 +285,13 @@ exports[`CSharpGenerator should render models and their dependencies 2`] = `
     public string? StreetName 
     {
       get { return streetName; }
-      set { streetName = value; }
+      set { this.streetName = value; }
     }
 
     public Dictionary<string, dynamic>? AdditionalProperties 
     {
       get { return additionalProperties; }
-      set { additionalProperties = value; }
+      set { this.additionalProperties = value; }
     }
   }
 }"
@@ -315,67 +315,67 @@ exports[`CSharpGenerator should render null-forgiving operator if handleNullable
   public string StreetName 
   {
     get { return streetName; }
-    set { streetName = value; }
+    set { this.streetName = value; }
   }
 
   public string City 
   {
     get { return city; }
-    set { city = value; }
+    set { this.city = value; }
   }
 
   public string State 
   {
     get { return state; }
-    set { state = value; }
+    set { this.state = value; }
   }
 
   public double HouseNumber 
   {
     get { return houseNumber; }
-    set { houseNumber = value; }
+    set { this.houseNumber = value; }
   }
 
   public bool? Marriage 
   {
     get { return marriage; }
-    set { marriage = value; }
+    set { this.marriage = value; }
   }
 
   public HouseType HouseType 
   {
     get { return houseType; }
-    set { houseType = value; }
+    set { this.houseType = value; }
   }
 
   public TerraceType? TerraceType 
   {
     get { return terraceType; }
-    set { terraceType = value; }
+    set { this.terraceType = value; }
   }
 
   public dynamic? Members 
   {
     get { return members; }
-    set { members = value; }
+    set { this.members = value; }
   }
 
   public dynamic[]? TupleType 
   {
     get { return tupleType; }
-    set { tupleType = value; }
+    set { this.tupleType = value; }
   }
 
   public string[] ArrayType 
   {
     get { return arrayType; }
-    set { arrayType = value; }
+    set { this.arrayType = value; }
   }
 
   public Dictionary<string, dynamic>? AdditionalProperties 
   {
     get { return additionalProperties; }
-    set { additionalProperties = value; }
+    set { this.additionalProperties = value; }
   }
 }"
 `;
diff --git a/test/generators/csharp/presets/__snapshots__/CommonPreset.spec.ts.snap b/test/generators/csharp/presets/__snapshots__/CommonPreset.spec.ts.snap
diff --git a/test/generators/csharp/presets/__snapshots__/JsonSerializerPreset.spec.ts.snap b/test/generators/csharp/presets/__snapshots__/JsonSerializerPreset.spec.ts.snap
diff --git a/test/generators/csharp/presets/__snapshots__/NewtonsoftSerializerPreset.spec.ts.snap b/test/generators/csharp/presets/__snapshots__/NewtonsoftSerializerPreset.spec.ts.snap

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ Array [`
`9`	`9`	`public IEnumerable<string>? Email`
`10`	`10`	`{`
`11`	`11`	`get { return email; }`
`12`		`- set { email = value; }`
	`12`	`+ set { this.email = value; }`
`13`	`13`	`}`
`14`	`14`	`}",`
`15`	`15`	`]`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ Array [`
`9`	`9`	`public string? Email`
`10`	`10`	`{`
`11`	`11`	`get { return email; }`
`12`		`- set { email = value; }`
	`12`	`+ set { this.email = value; }`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`public override bool Equals(object obj)`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public partial class Root`
`10`	`10`	`public string? Email`
`11`	`11`	`{`
`12`	`12`	`get { return email; }`
`13`		`- set { email = value; }`
	`13`	`+ set { this.email = value; }`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -12,25 +12,25 @@ Array [`
`12`	`12`	`public bool RequiredBoolean`
`13`	`13`	`{`
`14`	`14`	`get { return requiredBoolean; }`
`15`		`- set { requiredBoolean = value; }`
	`15`	`+ set { this.requiredBoolean = value; }`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`public bool? NotRequiredBoolean`
`19`	`19`	`{`
`20`	`20`	`get { return notRequiredBoolean; }`
`21`		`- set { notRequiredBoolean = value; }`
	`21`	`+ set { this.notRequiredBoolean = value; }`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`public string RequiredString`
`25`	`25`	`{`
`26`	`26`	`get { return requiredString; }`
`27`		`- set { requiredString = value; }`
	`27`	`+ set { this.requiredString = value; }`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public string? NotRequiredString`
`31`	`31`	`{`
`32`	`32`	`get { return notRequiredString; }`
`33`		`- set { notRequiredString = value; }`
	`33`	`+ set { this.notRequiredString = value; }`
`34`	`34`	`}`
`35`	`35`	`}",`
`36`	`36`	`]`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ Array [`
`9`	`9`	`public string[]? Email`
`10`	`10`	`{`
`11`	`11`	`get { return email; }`
`12`		`- set { email = value; }`
	`12`	`+ set { this.email = value; }`
`13`	`13`	`}`
`14`	`14`	`}",`
`15`	`15`	`]`
Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,6 @@ export const CSHARP_DEFAULT_CLASS_PRESET: CsharpClassPreset<CSharpOptions> = {`
`144`	`144`	`if (options?.autoImplementedProperties) {`
`145`	`145`	`return 'set;';`
`146`	`146`	`}`
`147`		- return `set { ${property.propertyName} = value; }`;
	`147`	+ return `set { this.${property.propertyName} = value; }`;
`148`	`148`	`}`
`149`	`149`	`};`
Original file line number	Diff line number	Diff line change
@@ -21,13 +21,13 @@ exports[`CSharpGenerator class renderer should be able to overwrite property pre
`21`	`21`	`public string? Property`
`22`	`22`	`{`
`23`	`23`	`get { return property; }`
`24`		`- set { property = value; }`
	`24`	`+ set { this.property = value; }`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`public Dictionary<string, string>? AdditionalProperties`
`28`	`28`	`{`
`29`	`29`	`get { return additionalProperties; }`
`30`		`- set { additionalProperties = value; }`
	`30`	`+ set { this.additionalProperties = value; }`
`31`	`31`	`}`
`32`	`32`	`}"`
`33`	`33`	`;
@@ -48,55 +48,55 @@ exports[`CSharpGenerator should render \`class\` type 1`] = `
`48`	`48`	`public string StreetName`
`49`	`49`	`{`
`50`	`50`	`get { return streetName; }`
`51`		`- set { streetName = value; }`
	`51`	`+ set { this.streetName = value; }`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`public string City`
`55`	`55`	`{`
`56`	`56`	`get { return city; }`
`57`		`- set { city = value; }`
	`57`	`+ set { this.city = value; }`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`public string State`
`61`	`61`	`{`
`62`	`62`	`get { return state; }`
`63`		`- set { state = value; }`
	`63`	`+ set { this.state = value; }`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`public double HouseNumber`
`67`	`67`	`{`
`68`	`68`	`get { return houseNumber; }`
`69`		`- set { houseNumber = value; }`
	`69`	`+ set { this.houseNumber = value; }`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`public bool? Marriage`
`73`	`73`	`{`
`74`	`74`	`get { return marriage; }`
`75`		`- set { marriage = value; }`
	`75`	`+ set { this.marriage = value; }`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`public dynamic? Members`
`79`	`79`	`{`
`80`	`80`	`get { return members; }`
`81`		`- set { members = value; }`
	`81`	`+ set { this.members = value; }`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`public dynamic[]? TupleType`
`85`	`85`	`{`
`86`	`86`	`get { return tupleType; }`
`87`		`- set { tupleType = value; }`
	`87`	`+ set { this.tupleType = value; }`
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`public string[] ArrayType`
`91`	`91`	`{`
`92`	`92`	`get { return arrayType; }`
`93`		`- set { arrayType = value; }`
	`93`	`+ set { this.arrayType = value; }`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`public Dictionary<string, dynamic>? AdditionalProperties`
`97`	`97`	`{`
`98`	`98`	`get { return additionalProperties; }`
`99`		`- set { additionalProperties = value; }`
	`99`	`+ set { this.additionalProperties = value; }`
`100`	`100`	`}`
`101`	`101`	`}"`
`102`	`102`	`;
@@ -218,55 +218,55 @@ exports[`CSharpGenerator should render models and their dependencies 1`] = `
`218`	`218`	`public string StreetName`
`219`	`219`	`{`
`220`	`220`	`get { return streetName; }`
`221`		`- set { streetName = value; }`
	`221`	`+ set { this.streetName = value; }`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`public string City`
`225`	`225`	`{`
`226`	`226`	`get { return city; }`
`227`		`- set { city = value; }`
	`227`	`+ set { this.city = value; }`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`public string State`
`231`	`231`	`{`
`232`	`232`	`get { return state; }`
`233`		`- set { state = value; }`
	`233`	`+ set { this.state = value; }`
`234`	`234`	`}`
`235`	`235`
`236`	`236`	`public double HouseNumber`
`237`	`237`	`{`
`238`	`238`	`get { return houseNumber; }`
`239`		`- set { houseNumber = value; }`
	`239`	`+ set { this.houseNumber = value; }`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`public bool? Marriage`
`243`	`243`	`{`
`244`	`244`	`get { return marriage; }`
`245`		`- set { marriage = value; }`
	`245`	`+ set { this.marriage = value; }`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`public dynamic? Members`
`249`	`249`	`{`
`250`	`250`	`get { return members; }`
`251`		`- set { members = value; }`
	`251`	`+ set { this.members = value; }`
`252`	`252`	`}`
`253`	`253`
`254`	`254`	`public dynamic[] ArrayType`
`255`	`255`	`{`
`256`	`256`	`get { return arrayType; }`
`257`		`- set { arrayType = value; }`
	`257`	`+ set { this.arrayType = value; }`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`public OtherModel? OtherModel`
`261`	`261`	`{`
`262`	`262`	`get { return otherModel; }`
`263`		`- set { otherModel = value; }`
	`263`	`+ set { this.otherModel = value; }`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`public Dictionary<string, dynamic>? AdditionalProperties`
`267`	`267`	`{`
`268`	`268`	`get { return additionalProperties; }`
`269`		`- set { additionalProperties = value; }`
	`269`	`+ set { this.additionalProperties = value; }`
`270`	`270`	`}`
`271`	`271`	`}`
`272`	`272`	`}"`
@@ -285,13 +285,13 @@ exports[`CSharpGenerator should render models and their dependencies 2`] = `
`285`	`285`	`public string? StreetName`
`286`	`286`	`{`
`287`	`287`	`get { return streetName; }`
`288`		`- set { streetName = value; }`
	`288`	`+ set { this.streetName = value; }`
`289`	`289`	`}`
`290`	`290`
`291`	`291`	`public Dictionary<string, dynamic>? AdditionalProperties`
`292`	`292`	`{`
`293`	`293`	`get { return additionalProperties; }`
`294`		`- set { additionalProperties = value; }`
	`294`	`+ set { this.additionalProperties = value; }`
`295`	`295`	`}`
`296`	`296`	`}`
`297`	`297`	`}"`
@@ -315,67 +315,67 @@ exports[`CSharpGenerator should render null-forgiving operator if handleNullable
`315`	`315`	`public string StreetName`
`316`	`316`	`{`
`317`	`317`	`get { return streetName; }`
`318`		`- set { streetName = value; }`
	`318`	`+ set { this.streetName = value; }`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`public string City`
`322`	`322`	`{`
`323`	`323`	`get { return city; }`
`324`		`- set { city = value; }`
	`324`	`+ set { this.city = value; }`
`325`	`325`	`}`
`326`	`326`
`327`	`327`	`public string State`
`328`	`328`	`{`
`329`	`329`	`get { return state; }`
`330`		`- set { state = value; }`
	`330`	`+ set { this.state = value; }`
`331`	`331`	`}`
`332`	`332`
`333`	`333`	`public double HouseNumber`
`334`	`334`	`{`
`335`	`335`	`get { return houseNumber; }`
`336`		`- set { houseNumber = value; }`
	`336`	`+ set { this.houseNumber = value; }`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`public bool? Marriage`
`340`	`340`	`{`
`341`	`341`	`get { return marriage; }`
`342`		`- set { marriage = value; }`
	`342`	`+ set { this.marriage = value; }`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`public HouseType HouseType`
`346`	`346`	`{`
`347`	`347`	`get { return houseType; }`
`348`		`- set { houseType = value; }`
	`348`	`+ set { this.houseType = value; }`
`349`	`349`	`}`
`350`	`350`
`351`	`351`	`public TerraceType? TerraceType`
`352`	`352`	`{`
`353`	`353`	`get { return terraceType; }`
`354`		`- set { terraceType = value; }`
	`354`	`+ set { this.terraceType = value; }`
`355`	`355`	`}`
`356`	`356`
`357`	`357`	`public dynamic? Members`
`358`	`358`	`{`
`359`	`359`	`get { return members; }`
`360`		`- set { members = value; }`
	`360`	`+ set { this.members = value; }`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`public dynamic[]? TupleType`
`364`	`364`	`{`
`365`	`365`	`get { return tupleType; }`
`366`		`- set { tupleType = value; }`
	`366`	`+ set { this.tupleType = value; }`
`367`	`367`	`}`
`368`	`368`
`369`	`369`	`public string[] ArrayType`
`370`	`370`	`{`
`371`	`371`	`get { return arrayType; }`
`372`		`- set { arrayType = value; }`
	`372`	`+ set { this.arrayType = value; }`
`373`	`373`	`}`
`374`	`374`
`375`	`375`	`public Dictionary<string, dynamic>? AdditionalProperties`
`376`	`376`	`{`
`377`	`377`	`get { return additionalProperties; }`
`378`		`- set { additionalProperties = value; }`
	`378`	`+ set { this.additionalProperties = value; }`
`379`	`379`	`}`
`380`	`380`	`}"`
`381`	`381`	`;