feat: add missing setter in union interface leading to compile errors in implementing classes (#2232)

* feat: add missing setter on union interface leading to compile errors in classes implementing that union

* Fix snapshot

---------

Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>

Author: ThomasVerhoeven1998

src/generators/java/JavaPreset.ts

@@ -48,6 +48,9 @@ export interface UnionPreset<R extends AbstractRenderer, O>
   discriminatorGetter?: (
     args: PresetArgs<R, O, ConstrainedUnionModel>
   ) => string;
+  discriminatorSetter?: (
+    args: PresetArgs<R, O, ConstrainedUnionModel>
+  ) => string;
 }
 
 export type RecordPresetType<O> = InterfacePreset<RecordRenderer, O>;

src/generators/java/renderers/UnionRenderer.ts

@@ -20,7 +20,8 @@ export class UnionRenderer extends JavaRenderer<ConstrainedUnionModel> {
     const content = [];
 
     if (this.model.options.discriminator) {
-      content.push(await this.runDiscriminatorAccessorPreset());
+      content.push(await this.runDiscriminatorGetterPreset());
+      content.push(await this.runDiscriminatorSetterPreset());
     }
     content.push(await this.runAdditionalContentPreset());
 
@@ -32,9 +33,13 @@ export class UnionRenderer extends JavaRenderer<ConstrainedUnionModel> {
     ]);
   }
 
-  runDiscriminatorAccessorPreset(): Promise<string> {
+  runDiscriminatorGetterPreset(): Promise<string> {
     return this.runPreset('discriminatorGetter');
   }
+
+  runDiscriminatorSetterPreset(): Promise<string> {
+    return this.runPreset('discriminatorSetter');
+  }
 }
 
 export const JAVA_DEFAULT_UNION_PRESET: UnionPresetType<JavaOptions> = {
@@ -49,5 +54,16 @@ export const JAVA_DEFAULT_UNION_PRESET: UnionPresetType<JavaOptions> = {
     return `${model.options.discriminator.type} get${FormatHelpers.toPascalCase(
       model.options.discriminator.discriminator
     )}();`;
+  },
+  discriminatorSetter({ model }) {
+    if (!model.options.discriminator?.type) {
+      return '';
+    }
+
+    return `void set${FormatHelpers.toPascalCase(
+      model.options.discriminator.discriminator
+    )}(${model.options.discriminator.type} ${FormatHelpers.toCamelCase(
+      model.options.discriminator.discriminator
+    )});`;
   }
 };

test/generators/java/__snapshots__/JavaGenerator.spec.ts.snap

@@ -12,6 +12,7 @@ Array [
  */
 public interface Animal {
   String getPetType();
+  void setPetType(String petType);
 }",
   "public class Boxer implements Animal, Dog {
   @JsonProperty(\\"breed\\")
@@ -144,6 +145,7 @@ Array [
  */
 public interface Vehicle {
   VehicleType getVehicleType();
+  void setVehicleType(VehicleType vehicleType);
 }",
   "public class Car implements Vehicle {
   private final VehicleType vehicleType = VehicleType.CAR;
@@ -301,6 +303,7 @@ Array [
  */
 public interface Pet {
   CloudEventType getType();
+  void setType(CloudEventType type);
 }",
   "public class Dog implements Pet {
   @NotNull
@@ -805,6 +808,7 @@ Array [
  */
 public interface Vehicle {
   VehicleType getVehicleType();
+  void setVehicleType(VehicleType vehicleType);
 }",
   "public class Cargo {
   @Valid

test/generators/java/presets/__snapshots__/JacksonPreset.spec.ts.snap

@@ -93,6 +93,7 @@ Array [
  */
 public interface Vehicle {
   String getVehicleType();
+  void setVehicleType(String vehicleType);
 }",
   "public class Car implements Vehicle {
   @JsonProperty(\\"vehicle_type\\")
@@ -151,6 +152,7 @@ Array [
  */
 public interface Vehicle {
   String getVehicleType();
+  void setVehicleType(String vehicleType);
 }",
   "public class Car implements Vehicle {
   @JsonProperty(\\"vehicleType\\")
@@ -197,6 +199,7 @@ Array [
  */
 public interface Vehicle {
   String getVehicleType();
+  void setVehicleType(String vehicleType);
 }",
   "public class Car implements Vehicle {
   @JsonProperty(\\"vehicleType\\")