feat: add required field management in csharp newtonsoft serializer #2117
Conversation
fr-th
requested review from
asyncapi-bot-eve,
jonaslagoni,
kennethaasan and
magicmatatjahu
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modelina canceled.
|
|
jonaslagoni
left a comment
jonaslagoni
left a comment
There was a problem hiding this comment.
Do you want to continue with enforceRequired or make it part of the default rendering process?
All you need to make the changes on the next branch instead of master, but up to you 🙂
jonaslagoni
left a comment
jonaslagoni
left a comment
There was a problem hiding this comment.
** Still need to review 😄
Pull Request Test Coverage Report for Build 12964805542Details
💛 - Coveralls |
|
Ah damn, I missed the part for the 'next' branch sorry. |
jonaslagoni
changed the title
|
Lets just do master. |
|
|
@all-contributors please add @fr-th for code, test, docs |
|
I've put up a pull request to add @fr-th! 🎉 |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Description
When generating c# model with newtonsoft serialization, an option now allows to prevent deserialization if required fields are missing
Related Issue
#2114
Checklist
npm run lint).npm run test).Additional Notes