[BUG] TypeScript generator for Date property type

[roman-supy-io]

Describe the bug.

The Typescript generator does not respect the

{ "type": "string", "format": "date-time" }

The output is expected to be

deliveryDate: Date;

Instead it is generated as:

deliveryDate: string;

The issue looks similar to [https://github.com//issues/1607](This Issue) but is Typescript-related

Expected behavior

The Date type should generated and not a string

Screenshots

How to Reproduce

1. Use a schema with a property defined as { "type": "string", "format": "date-time" }
2. run npx modelina generate typescript ...
3. inspect the generated output's class/interface

🥦 Browser

None

👀 Have you checked for similar open issues?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to work on this issue ?

None

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[jonaslagoni]

Should be pretty easy fix, here is how we do it for Java:

modelina/src/generators/java/JavaConstrainer.ts

Line 172 in b38dd6c

switch (constrainedModel.options.format) {

Should be applied here: https://github.com/asyncapi/modelina/blob/master/src/generators/typescript/TypeScriptConstrainer.ts#L34

Make sure to target next branch as this is a breaking change

[roman-supy-io]

@jonaslagoni when could it be released?
Because we need it ASAP and I want to understand if we should fork and release or wait for this package to be released

[jonaslagoni]

@roman-supy-io if you make the change and provide a PR it can be released right after 🙂

Or you can do it locally with a script instead of the CLI: https://modelina.org/examples?selectedExample=change-type-mapping

It's basically like pushing the changes to here🙂

[roman-supy-io]

@jonaslagoni here it is
#2192

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

[kunal-595]

Hi, I’d like to work on this issue if it’s available.
Could you please assign it to me?

[AarishMansur]

Hey @roman-supy-io I have pushed my PR
lemme know if some changes are needed
Thanks !!

[asyncapi-bot]

🎉 This issue has been resolved in version 6.0.0-next.6 🎉

The release is available on:

• npm package (@next dist-tag)
• npm package (@next dist-tag)
• GitHub release

Your semantic-release bot 📦🚀