Skip to content

chore: update runtime-go-testing workflow to Node.js 20#2437

Merged
jonaslagoni merged 1 commit intoasyncapi:masterfrom
Varadraj75:chore/update-ci-node-version
Feb 10, 2026
Merged

chore: update runtime-go-testing workflow to Node.js 20#2437
jonaslagoni merged 1 commit intoasyncapi:masterfrom
Varadraj75:chore/update-ci-node-version

Conversation

@Varadraj75
Copy link
Contributor

Description

This pull request updates the runtime-go-testing.yml CI workflow to use Node.js 20 instead of Node.js 14, which has reached End of Life.
The change ensures the CI environment aligns with currently supported Node.js versions and avoids potential issues with modern tooling and dependencies.

This update is limited to CI configuration and does not affect the runtime behavior or public API of the library.

Related Issue

Closes #2424

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

The CI failure observed after upgrading Node.js is due to an existing issue in the Go generator logic, which will be tracked separately. This PR intentionally focuses only on updating the CI Node.js version.

Copilot AI review requested due to automatic review settings February 9, 2026 12:36
@netlify
Copy link

netlify bot commented Feb 9, 2026

Deploy Preview for modelina failed.

Name Link
🔨 Latest commit 78be8db
🔍 Latest deploy log https://app.netlify.com/projects/modelina/deploys/698a13e4be5a1800080d67ba

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Go runtime testing GitHub Actions workflow to use a supported Node.js version (Node 20) instead of the EOL Node 14, addressing issue #2424 and keeping CI aligned with modern tooling.

Changes:

  • Bump Node.js version in runtime-go-testing.yml from 14 to 20.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Varadraj75
Copy link
Contributor Author

Hi @jonaslagoni 👋

This PR updates the runtime-go-testing.yml workflow to use Node.js 20 instead of the EOL Node.js 14, as discussed in #2424.
All automated checks and quality gates have passed.

Whenever you have time, could you please take a look and let me know if everything looks good or if any changes are needed from my side?

Thanks a lot!

@coveralls
Copy link

coveralls commented Feb 9, 2026

Pull Request Test Coverage Report for Build 21833819090

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.997%

Totals Coverage Status
Change from base Build 21801656152: 0.0%
Covered Lines: 6942
Relevant Lines: 7421

💛 - Coveralls

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you cross polluted changes? 🤔

@Varadraj75 Varadraj75 force-pushed the chore/update-ci-node-version branch from 0c765f0 to 78be8db Compare February 9, 2026 17:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2026

@Varadraj75
Copy link
Contributor Author

@jonaslagoni, thanks for catching that
You’re absolutely right — an unrelated fix commit was accidentally included.

I’ve now removed the cross-polluted changes and force-pushed the branch so this PR only updates the CI Node.js version.

Appreciate the review — please let me know if everything looks good now.

@Varadraj75
Copy link
Contributor Author

Just to clarify for visibility:
– This PR only updates the Node.js version in runtime-go-testing.yml
– Netlify and docs-related failures are unrelated to this change
– The earlier cross-polluted commit has been removed

Happy to re-run checks or split things further if needed.
Thanks!

@Varadraj75
Copy link
Contributor Author

@jonaslagoni ,

Since this PR triggered a mix of CI, Netlify, and infra-related failures (many unrelated to the actual Node.js version bump), would it make sense to sync briefly on Slack?

I’d like to understand the expected behavior and batch any required fixes properly, instead of iterating via multiple PRs and force-pushes.

Happy to handle all necessary follow-ups to get everything fully green and aligned 👍
Thanks!

@jonaslagoni jonaslagoni merged commit ff1e8ff into asyncapi:master Feb 10, 2026
31 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] CI workflow uses Node.js 14 (EOL) instead of a supported version

3 participants