chore: update runtime-go-testing workflow to Node.js 20#2437
chore: update runtime-go-testing workflow to Node.js 20#2437jonaslagoni merged 1 commit intoasyncapi:masterfrom
Conversation
❌ Deploy Preview for modelina failed.
|
There was a problem hiding this comment.
Pull request overview
Updates the Go runtime testing GitHub Actions workflow to use a supported Node.js version (Node 20) instead of the EOL Node 14, addressing issue #2424 and keeping CI aligned with modern tooling.
Changes:
- Bump Node.js version in
runtime-go-testing.ymlfrom 14 to 20.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @jonaslagoni 👋 This PR updates the Whenever you have time, could you please take a look and let me know if everything looks good or if any changes are needed from my side? Thanks a lot! |
Pull Request Test Coverage Report for Build 21833819090Details
💛 - Coveralls |
jonaslagoni
left a comment
There was a problem hiding this comment.
Looks like you cross polluted changes? 🤔
0c765f0 to
78be8db
Compare
|
|
@jonaslagoni, thanks for catching that I’ve now removed the cross-polluted changes and force-pushed the branch so this PR only updates the CI Node.js version. Appreciate the review — please let me know if everything looks good now. |
|
Just to clarify for visibility: Happy to re-run checks or split things further if needed. |
|
Since this PR triggered a mix of CI, Netlify, and infra-related failures (many unrelated to the actual Node.js version bump), would it make sense to sync briefly on Slack? I’d like to understand the expected behavior and batch any required fixes properly, instead of iterating via multiple PRs and force-pushes. Happy to handle all necessary follow-ups to get everything fully green and aligned 👍 |



Description
This pull request updates the
runtime-go-testing.ymlCI workflow to use Node.js 20 instead of Node.js 14, which has reached End of Life.The change ensures the CI environment aligns with currently supported Node.js versions and avoids potential issues with modern tooling and dependencies.
This update is limited to CI configuration and does not affect the runtime behavior or public API of the library.
Related Issue
Closes #2424
Checklist
npm run lint).npm run test).Additional Notes
The CI failure observed after upgrading Node.js is due to an existing issue in the Go generator logic, which will be tracked separately. This PR intentionally focuses only on updating the CI Node.js version.