Skip to content

feat: disable visualizer reload on save#281

Merged
Ruchip16 merged 4 commits intoasyncapi:masterfrom
techmannih:refresh
Jul 7, 2025
Merged

feat: disable visualizer reload on save#281
Ruchip16 merged 4 commits intoasyncapi:masterfrom
techmannih:refresh

Conversation

@techmannih
Copy link
Contributor

Description

  • Added new VS Code setting: asyncapiPreview.autoReloadVisualizerOnSave
  • Visualizer now only reloads on save if the setting is enabled and panel is open
  • Updated README to include details of the new setting

Related issue(s)

Resolves #280

Video:

Video_2025-07-03_01-37-18.mp4

Copy link
Collaborator

@Ruchip16 Ruchip16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me, but why some tests are being skipped in CI is what i am wondering here

@techmannih
Copy link
Contributor Author

@Ruchip16 thanks for reviewing, yeah some workflow are skipping which are waiting review for code owener

@Ruchip16
Copy link
Collaborator

Ruchip16 commented Jul 3, 2025

@Ruchip16 thanks for reviewing, yeah some workflow are skipping which are waiting review for code owener

also one question: does this functionality need a setting? like Isn’t it just enough to check if the panel is open when saving, instead of adding a setting?
cc: @ivangsa

@ivangsa
Copy link
Collaborator

ivangsa commented Jul 3, 2025

hi @techmannih I see there is some bits of code that calculates if the pannel is open before reloading... This solves the actual issue of the Visualizer opening on save because an incomplete "reload" implementation..
I think this will do the trick!

Yes, I think it's better to always reload the pannel, as long as it was already open.. without adding more settings.. As a user I don't see a reason to disable this (aside from the current bug/issue)

Copy link
Collaborator

@ivangsa ivangsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep the code that checks if the visualizer is already open
and remove the user setting for this
and thanks for this feature it looks promising

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2025

@techmannih
Copy link
Contributor Author

Hi @Ruchip16 @ivangsa
I’ve removed the user setting as you suggested. It’s working fine now without the extra setting.
Thanks

@techmannih techmannih changed the title feat: add setting to disable visualizer reload on save feat: disable visualizer reload on save Jul 4, 2025
@techmannih
Copy link
Contributor Author

techmannih commented Jul 6, 2025

@ivangsa @Ruchip16 can you review this PR I have updated
Thanks

@ivangsa
Copy link
Collaborator

ivangsa commented Jul 7, 2025

Yes, as soon as @Ruchip16 tests everything it's working it would be merged...
Thanks a lot @techmannih

@Ruchip16 Ruchip16 requested a review from ivangsa July 7, 2025 09:50
@Ruchip16 Ruchip16 merged commit 10efd9f into asyncapi:master Jul 7, 2025
13 checks passed
@Ruchip16
Copy link
Collaborator

Ruchip16 commented Jul 7, 2025

thanks @techmannih for your contribution 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@techmannih
Copy link
Contributor Author

Thanks you so much @Ruchip16 @ivangsa for merging my first PR, I am happy to contribute on this project. Is there any other for me, I am excited to resolved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow turning off of Event Visualizer on save

4 participants

Comments