fix: refactor lighthouse failing check (#4170)

Co-authored-by: Sambhav  Gupta <sambhavgupta0705@gmail.com>
Co-authored-by: Chan <bot+chan@asyncapi.io>
Co-authored-by: Rohit <108233235+TRohit20@users.noreply.github.com>
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>

Author: 4 people

.github/workflows/lighthouse-ci.yml

@@ -35,7 +35,7 @@ jobs:
         run: echo "shouldrun=true" >> $GITHUB_OUTPUT
         
       - if: steps.should_run.outputs.shouldrun == 'true'
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - if: steps.should_run.outputs.shouldrun == 'true'
         name: Await Netlify Preview
@@ -46,18 +46,26 @@ jobs:
           max_timeout: 600
 
       - if: steps.should_run.outputs.shouldrun == 'true'
-        name: Lighthouse Audit
+        name: Run Lighthouse Audit
         id: lighthouse_audit
         uses: treosh/lighthouse-ci-action@03becbfc543944dd6e7534f7ff768abb8a296826 #version 10.1 https://github.com/treosh/lighthouse-ci-action/releases/tag/10.1.0
         with:
           urls: |
             https://deploy-preview-$PR_NUMBER--asyncapi-website.netlify.app/
           configPath: ./.github/workflows/lighthouserc.json
-          uploadArtifacts: true
+          uploadArtifacts: false
           temporaryPublicStorage: true
         env:
           PR_NUMBER: ${{ github.event.pull_request.number}}
 
+      - if: steps.should_run.outputs.shouldrun == 'true'
+        name: Upload Lighthouse Artifacts
+        uses: actions/upload-artifact@v4
+        with:
+          name: lighthouse-report
+          path: .lighthouseci
+          include-hidden-files: true
+
       - if: steps.should_run.outputs.shouldrun == 'true'
         name: Lighthouse Score Report
         id: lighthouse_score_report

.github/workflows/lighthouserc.json

@@ -1,23 +1,23 @@
 {
-    "ci": {
-      "assert": {
-        "assertions": {
-          "categories:accessibility": ["error", {"minScore": 0.98}],
-          "categories:best-practices": ["error", {"minScore": 0.92}],
-          "categories:seo": ["error", {"minScore": 1.00}]
-        }
-      },
-      "collect": {
-        "settings": {
-          "skipAudits": [
-            "robots-txt",
-            "canonical",
-            "tap-targets",
-            "is-crawlable",
-            "works-offline",
-            "offline-start-url"
-          ]
-        }
+  "ci": {
+    "assert": {
+      "assertions": {
+        "categories:accessibility": ["error", {"minScore": 0.98}],
+        "categories:best-practices": ["error", {"minScore": 0.92}],
+        "categories:seo": ["error", {"minScore": 1.00}]
+      }
+    },
+    "collect": {
+      "settings": {
+        "skipAudits": [
+          "robots-txt",
+          "canonical",
+          "tap-targets",
+          "is-crawlable",
+          "works-offline",
+          "offline-start-url"
+        ]
       }
     }
   }
+}