Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in tools section to specific category do not work #2181

Closed
derberg opened this issue Sep 28, 2023 · 21 comments · Fixed by #3116
Closed

Links in tools section to specific category do not work #2181

derberg opened this issue Sep 28, 2023 · 21 comments · Fixed by #3116
Labels

Comments

@derberg
Copy link
Member

derberg commented Sep 28, 2023

I try https://www.asyncapi.com/tools#Documentation%20Generators

and I guess it do not take me to proper section because of page load delay

<div class="my-8" id="Documentation Generators"> is in place, so anchor is correct. Although best anchors are without spaces.

so yeah, might be cause by delay of loading the view, something to check and figure out

@derberg derberg added the bug label Sep 28, 2023
@akshatnema akshatnema added the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Sep 30, 2023
@aryanas159
Copy link
Contributor

can i be assigned to this issue?

@aryanas159
Copy link
Contributor

I think the issue is caused because the javascript is executing before the DOM is rendered, is setting a setTimeout a good fix for this issue?

@akshatnema
Copy link
Member

akshatnema commented Sep 30, 2023

Hey @aryanas159, you can work on this.

I think the issue is caused because the javascript is executing before the DOM is rendered, is setting a setTimeout a good fix for this issue?

Nope, you should use some better approach to solve this problem. Maybe useRouter and useEffect can help you to scroll down to that heading.

@aryanas159
Copy link
Contributor

Hey @aryanas159, you can work on this.

I think the issue is caused because the javascript is executing before the DOM is rendered, is setting a setTimeout a good fix for this issue?

Nope, you should use some better approach to solve this problem. Maybe useRouter and useEffect can help you to scroll down to that heading.
@akshatnema Thanks for assigning the issue to me.
I have fixed it with useffect and userouter, but the useffect is executing before the DOM is rendered, if I add a delay of 1s it's working fine.

@akshatnema
Copy link
Member

What if you can use scroll margin and set it to the heading on which it should render?

@aryanas159
Copy link
Contributor

Untitled.video.-.Made.with.Clipchamp.3.mp4

How does this look?

@akshatnema
Copy link
Member

How does this look?

It's fine but it's better that we don't use setTimeout here and also, the scroll margin should be set accordingly, in order to get the heading on the initial render. Heading shouldn't get scrolled above as seen in the video.

@aryanas159
Copy link
Contributor

The issue is that the loading state has a timeout of 1s set to it, so the component is rendered only after 1s, we have to match that delay for scrolling as well.

aryanas159 added a commit to aryanas159/AsyncAPI that referenced this issue Oct 1, 2023
akshatnema added a commit to aryanas159/AsyncAPI that referenced this issue Oct 20, 2023
aryanas159 added a commit to aryanas159/AsyncAPI that referenced this issue Oct 21, 2023
akshatnema added a commit to aryanas159/AsyncAPI that referenced this issue Oct 21, 2023
akshatnema added a commit to aryanas159/AsyncAPI that referenced this issue Dec 7, 2023
aryanas159 added a commit to aryanas159/AsyncAPI that referenced this issue Dec 8, 2023
aryanas159 added a commit to aryanas159/AsyncAPI that referenced this issue Dec 8, 2023
aryanas159 added a commit to aryanas159/AsyncAPI that referenced this issue Dec 8, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@sambhavgupta0705
Copy link
Member

@aryanas159 any progress??

@nikhil-3112
Copy link

@derberg I am ready to fix this issue.

@aryanas159
Copy link
Contributor

@sambhavgupta0705 My proposed solution wasn't working for the maintainers, I think @nikhil-3112 should give it a go.

@nikhil-3112
Copy link

nikhil-3112 commented Mar 20, 2024

@derberg
Below are some Possible solutions-

Analyze Current Performance:

Use browser developer tools or online performance analysis tools to check the current loading speed of the page. Identify any performance bottlenecks that may be causing delays.

Optimize Images:

Check if there are any large images on the page that could be optimized for faster loading. Compress and resize them if necessary.

Minify CSS, JavaScript, and HTML:

Ensure that your CSS, JavaScript, and HTML files are minified to reduce their size and improve loading speed.

Enable Compression:

Make sure GZIP or Brotli compression is enabled on your server to compress files before transmitting them over the network.

Leverage Browser Caching:

Set appropriate caching headers for static assets to instruct the browser to cache them locally and reduce the need for repeated downloads.

Reduce HTTP Requests:

Combine and minimize CSS and JavaScript files to reduce the number of HTTP requests needed to load the page.

Load JavaScript Asynchronously:

If there are non-essential JavaScript files, consider loading them asynchronously using the async attribute to prevent them from blocking the page load.

Prioritize Above-the-Fold Content:

Ensure that critical CSS and JavaScript needed for rendering above-the-fold content are loaded and executed as early as possible.

Optimize Server Response Time:

Optimize server-side code and database queries to reduce response times and improve overall page loading speed.

Use Content Delivery Networks (CDNs):

Utilize a CDN to distribute static assets closer to users and reduce latency.

@nikhil-3112
Copy link

Solving this issue by Loading JavaScript asynchronously

@nikhil-3112
Copy link

Already JavaScript is loading asynchronously. Trying Optimize server response time.

@nikhil-3112
Copy link

I think the issue is solved

@sambhavgupta0705
Copy link
Member

Nope it is not

Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 23, 2024
@JeelRajodiya
Copy link
Contributor

Is this still relevant?

@sambhavgupta0705
Copy link
Member

Yes

@sambhavgupta0705
Copy link
Member

@JeelRajodiya if you want to then you can work on this one

@github-actions github-actions bot removed the stale label Jul 26, 2024
@sambhavgupta0705 sambhavgupta0705 removed the Hacktoberfest Label issues as available for participants of https://hacktoberfest.digitalocean.com label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment