Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Use env variables to load api keys and secrets #2802

Closed
2 tasks done
maverox opened this issue Mar 21, 2024 · 6 comments
Closed
2 tasks done

Feat: Use env variables to load api keys and secrets #2802

maverox opened this issue Mar 21, 2024 · 6 comments

Comments

@maverox
Copy link

maverox commented Mar 21, 2024

Why do we need this improvement?

Exposed keys are not good for security and integrity, hence it is necessary to have this change

How will this change help?

It will help by securing exposed Api keys and secrets

Screenshots

No response

How could it be implemented/designed?

Yes it can be implemented simply by using .env files and loading the environment variables

🚧 Breaking changes

Yes

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sambhavgupta0705
Copy link
Member

@maverox where when do have keys currently exposed?

@maverox
Copy link
Author

maverox commented Mar 21, 2024 via email

@sambhavgupta0705
Copy link
Member

You can DM me on slack

@sambhavgupta0705
Copy link
Member

@maverox I talked to @akshatnema and we came to a conclusion that it is not creating any problem to us so we are not planning to removing it for now

@sambhavgupta0705
Copy link
Member

closing this as not planned for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants