Skip to content

Commit d8e8f8c

Browse files
authored
fix(test): Stringify versions to avoid incorrect Docker tag resolution (#318)
motivation: Numeric version like 5.0 resolve to '5', which pulls the latest 5.x version. This caused tests to break due to version mismatches. modifications: Stringify versions results: TestContainer now pulls the correct MySQL image, and tests run reliably.
1 parent bae7e03 commit d8e8f8c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/ci-integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
matrix:
1212
mysql-version:
13-
[5.5, 5.6.45, 5.6, 5.7.28, 5.7, 8.0, 8.1, 8.2, 8.3, 8.4, 9.0]
13+
['5.5', '5.6.45', '5.6', '5.7.28', '5.7', '8.0', '8.1', '8.2', '8.3', '8.4', '9.0', '9.1', '9.2']
1414
name: Integration test with MySQL ${{ matrix.mysql-version }}
1515
steps:
1616
- uses: actions/checkout@v3

.github/workflows/ci-mariadb-intergration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
strategy:
1111
matrix:
1212
mariadb-version:
13-
[10.0, 10.1, 10.2.15, 10.2, 10.3.7, 10.3, 10.5.1, 10.5, 10.6, 10.11]
13+
['10.0', '10.1', '10.2.15', '10.2', '10.3.7', '10.3', '10.5.1', '10.5', '10.6', '10.11']
1414
name: Integration test with MariaDB ${{ matrix.mariadb-version }}
1515
steps:
1616
- uses: actions/checkout@v3

0 commit comments

Comments
 (0)