Can't install xpadneo on OSMC Raspberry-Pi 4 version

[SchwingMC]

Version of xpadneo

v0.9-63-gf17a4e2

Severity / Impact

• I've read the docs and the bug reporting instructions
• It does not work at all
• It used to work in a previous version
• It mostly works but sometimes it doesn't
• I found a work-around
• I probably didn't figure it all out but it's too early to give up
• I don't know how to ...
• It's too complicated
• Fantastic work but ...
• I can code and I want to help

Describe the bug

During installation the error message "Error! Bad return status for module build on kernel: 5.10.32-1-osmc (aarch64)" is given.
lsmod | grep hid_xpadneo returns nothing. sudo modprobe hid_xpadneo gives error message "modprobe: FATAL: Module hid_xpadneo not found in directory /lib/modules/5.10.32-1-osmc"

Steps to Reproduce

I followed the installation instruction for osmc as outlined on the front page.

Expected behavior

Screenshots/Gifs

System information

# uname -a

Linux osmc 5.10.32-1-osmc #1 SMP PREEMPT Wed Apr 28 05:45:57 UTC 2021 aarch64 GNU/Linux

# xxd -c20 -g1 /sys/module/hid_xpadneo/drivers/hid:xpadneo/0005:045E:*/report_descriptor | tee >(cksum)

xxd: /sys/module/hid_xpadneo/drivers/hid:xpadneo/0005:045E:*/report_descriptor: No such file or directory

Controller and Bluetooth information

Additional context

[kakra]

Do you have any more context, e.g. the build log?

[SchwingMC]

`osmc@osmc:~/xpadneo$ sudo ./install.sh

• creating dkms.conf
• installing module (using DKMS)

Creating symlink /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/source ->
/usr/src/hid-xpadneo-v0.9-63-gf17a4e2

DKMS: add completed.

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area...
make -j4 KERNELRELEASE=5.10.32-1-osmc -C /lib/modules/5.10.32-1-osmc/build M=/va r/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src VERSION=v0.9-63-gf17a4e2 modul es...(bad exit status: 2)
Error! Bad return status for module build on kernel: 5.10.32-1-osmc (aarch64)
Consult /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/make.log for more infor mation.
`

[SchwingMC]

DKMS make.log for hid-xpadneo-v0.9-63-gf17a4e2 for kernel 5.10.32-1-osmc (aarch64)
Wed Jun 2 23:05:26 CEST 2021
make: Entering directory '/usr/src/rbp2-headers-5.10.32-1-osmc'
CC [M] /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src/hid-xpadneo.o
gcc: error: unrecognized command line option '-mgeneral-regs-only'
make[1]: *** [scripts/Makefile.build:279: /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src/hid-xpadneo.o] Error 1
make: *** [Makefile:1824: /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src] Error 2
make: Leaving directory '/usr/src/rbp2-headers-5.10.32-1-osmc'

[kakra]

gcc: error: unrecognized command line option '-mgeneral-regs-only'

As far as I know, this isn't an option that we do set. Which gcc version are you using?

[SchwingMC]

gcc --version outputs this:
gcc (Debian 8.3.0-6) 8.3.0

[kakra]

Please try sudo ARCH=arm ./install.sh. Does it work then?

[SchwingMC]

Hi, this did something. Installation now gives no error message.
But lsmod | grep hid_xpadneo still returns nothing and sudo modprobe hid_xpadneo returns modprobe: ERROR: could not insert 'hid_xpadneo': Exec format error. As far as I know this should not happen.
Build log gives :
DKMS make.log for hid-xpadneo-v0.9-63-gf17a4e2 for kernel 5.10.32-1-osmc (aarch64)
Thu Jun 3 20:41:32 CEST 2021
make: Entering directory '/usr/src/rbp2-headers-5.10.32-1-osmc'
CC [M] /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src/hid-xpadneo.o
MODPOST /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src/Module.symvers
CC [M] /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src/hid-xpadneo.mod.o
LD [M] /var/lib/dkms/hid-xpadneo/v0.9-63-gf17a4e2/build/src/hid-xpadneo.ko
make: Leaving directory '/usr/src/rbp2-headers-5.10.32-1-osmc'

I should mention there is a second make.log in /var/lib/dkms/hid-xpadneo/kernel-5.10.32-1-osmc-aarch64/log
It has the same content as the given log. I don't know if this is normal.

[kakra]

Maybe ARCH=aarch64 is needed instead? At least we are onto something. Actually, I found the hint about ARCH on a website about RPi3 while researching your problem. It looks like the aforementioned -mgeneral-regs-only is a compiler flag exclusively supported for ARM processors. This may indicate that some configuration is broken in the RPi OS, as apparently the kernel make files try to use that option but the GCC compiler does not feel like doing so - unless you specify the architecture.

Exec format error usually tells us that the executable code is not targeted for the current architecture, so we probably just need to find the right parameter for ARCH.

You're not trying to make the module from a cross-compilation environment, or are you? (that is, compiling on a different host than the target)

[SchwingMC]

sudo ARCH=aarch64 ./install.sh gives the same error as the normal installation process : Error! Bad return status for module build on kernel: 5.10.32-1-osmc (aarch64)
The make.log content is:
DKMS make.log for hid-xpadneo-v0.9-63-gf17a4e2 for kernel 5.10.32-1-osmc (aarch64)
Thu Jun 3 22:16:42 CEST 2021
make: Entering directory '/usr/src/rbp2-headers-5.10.32-1-osmc'
Makefile:682: arch/aarch64/Makefile: No such file or directory
make: *** No rule to make target 'arch/aarch64/Makefile'. Stop.
make: Leaving directory '/usr/src/rbp2-headers-5.10.32-1-osmc'

You're not trying to make the module from a cross-compilation environment, or are you?

I installed osmc with the official windows app as outlined here: https://discourse.osmc.tv/t/testing-kodi-v19-builds-for-raspberry-pi-2-3-4/89152

I just noticed that it is mentioned that buster-devel is the default repository for that build, is this maybe the source of error?
The xpadneo installation is done via ssh.

[kakra]

Try with ARCH=arm64. It seems to expect a directory name from the linux/arch directory.

[SchwingMC]

Trying sudo ARCH=arm64 ./install.sh doesn't work. It results in the known error: "Error! Bad return status for module build on kernel: 5.10.32-1-osmc (aarch64)" , with the gcc error in the make.log.

[kakra]

I'd guess that this is a bug in OSMC then... We don't do anything special, we just use existing kernel build infrastructure, and that seems to be broken. We could maybe work around it from xpadneo somehow, but TBH, that approach doesn't look right. If the guys from OSMC suggest a way to properly work around that issue, I'm willing to put it into xpadneo, but without access to a real physical system, I don't think there's much I can help with currently, other than suggesting to upgrade to a newer gcc version, or trying CC=clang or CC=gcc-8.1 instead or something (if the system had multiple compiler versions).

[SchwingMC]

Ok, the people at OSMC mentioned that the problem seems to be building a 64-bit kernel module in a 32-bit userspace.
To build it natively on a raspberry pi 4 aarch64-toolchain-osmc is needed.
I have not managed to do that succesfully yet, I will tell you, if I do.

[kakra]

Okay, we can add that to the documentation then.

[defanator]

@SchwingMC any luck in building xpadneo under OSMC? I'm facing exactly the same issue, still trying to figure out how to proceed.