Update and centralize the C constants (#691)

* Centralize constants

* Adjusted constants to the one used in PhysConstant.m

* Updated test_physics for the new constants


Co-authored-by: Laurent Farvacque <[email protected]>

Author: JeanLucPons

atintegrators/BeamLoadingCavityPass.c

@@ -1,3 +1,4 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atimplib.c"
 #include "attrackfunc.c"
@@ -6,8 +7,6 @@
  * BeamLoadingCavity pass method by Simon White.  
  *
  */
- 
-#define C0     2.99792458e8 
 
 struct elem
 {

atintegrators/BndMPoleSymplectic4E2Pass.c

@@ -1,12 +1,8 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "atphyslib.c"
 
-#define DRIFT1    0.6756035959798286638
-#define DRIFT2   -0.1756035959798286639
-#define KICK1     1.351207191959657328
-#define KICK2    -1.702414383919314656
-
 struct elem
 {
     double Length;

atintegrators/BndMPoleSymplectic4E2RadPass.c

@@ -1,12 +1,8 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "atphyslib.c"
 
-#define DRIFT1    0.6756035959798286638
-#define DRIFT2   -0.1756035959798286639
-#define KICK1     1.351207191959657328
-#define KICK2    -1.702414383919314656
-
 #define SQR(X) ((X)*(X))
 
 struct elem
@@ -44,10 +40,6 @@ struct elem
  Last modified on 8/26/2009
  */
 
-
-#define TWOPI     6.28318530717959
-#define CGAMMA    8.846056192e-05
-
 static double B2perp(double bx, double by, double irho, 
                             double x, double xpr, double y, double ypr)
 /* Calculates sqr(|e x B|) , where e is a unit vector in the direction of velocity  */    

atintegrators/BndMPoleSymplectic4Pass.c

@@ -1,14 +1,10 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "atphyslib.c"
 #include "driftkick.c"		/* fastdrift and bndthinkick */
 #include "quadfringe.c"		/* QuadFringePassP, QuadFringePassN */
 
-#define DRIFT1    0.6756035959798286638
-#define DRIFT2   -0.1756035959798286639
-#define KICK1     1.351207191959657328
-#define KICK2    -1.702414383919314656
-
 struct elem
 {
     double Length;

atintegrators/BndMPoleSymplectic4QuantPass.c

@@ -1,3 +1,4 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "atphyslib.c"
@@ -6,11 +7,6 @@
 #include "quadfringe.c"		/* QuadFringePassP, QuadFringePassN */
 #include <math.h>
 
-#define DRIFT1    0.6756035959798286638
-#define DRIFT2   -0.1756035959798286639
-#define KICK1     1.351207191959657328
-#define KICK2    -1.702414383919314656
-
 struct elem
 {
     double Length;

atintegrators/BndMPoleSymplectic4RadPass.c

@@ -1,14 +1,10 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "atphyslib.c"
 #include "driftkickrad.c"	/* bndthinkickrad.c */
 #include "quadfringe.c"		/* QuadFringePassP, QuadFringePassN */
 
-#define DRIFT1    0.6756035959798286638
-#define DRIFT2   -0.1756035959798286639
-#define KICK1     1.351207191959657328
-#define KICK2    -1.702414383919314656
-
 struct elem
 {
     double Length;

atintegrators/BndStrMPoleSymplectic4Pass.c

@@ -1,13 +1,9 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "atphyslib.c"
 #include "driftkick.c"  /* strthinkick.c */
 
-#define DRIFT1    0.6756035959798286638
-#define DRIFT2   -0.1756035959798286639
-#define KICK1     1.351207191959657328
-#define KICK2    -1.702414383919314656
-
 /* Straight dipole w/ multipole using Symplectic Integration and rotation at
  * dipole faces.
  * Created by Xiaobiao Huang, 7/31/2018 */

atintegrators/CavityPass.c

@@ -4,12 +4,9 @@
  * Revision 3/10/04
  * A.Terebilo
  */
-
+#include "atconstants.h"
 #include "atelem.c"
 
-#define TWOPI  6.28318530717959
-#define C0  	2.99792458e8
-
 struct elem
 {
     double Length;

atintegrators/DeltaQPass.c

@@ -1,8 +1,7 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 
-#define TWOPI		6.28318530717959
-
 struct elem 
 {
   double Alphax;

atintegrators/ExactMultipolePass.c

@@ -1,26 +1,10 @@
+#include "atconstants.h"
 #include "atelem.c"
 #include "atlalib.c"
 #include "driftkick.c"  /* fastdrift.c, strthinkick.c */
 #include "exactdrift.c"
 #include "exactmultipolefringe.c"
 
-/* Generated by:
-
-#!/usr/bin/env python
-c1 = 1.0/(2.0*(2.0-2.0**(1.0/3.0)))
-c2 = (1-2**(1.0/3.0))/(2.0*(2.0-2.0**(1.0/3.0)))
-d1 = 1.0/(2.0-2.0**(1.0/3.0))
-d2 = -(2**(1.0/3.0)/(2.0-2.0**(1.0/3.0)))
-print(f"#define DRIFT1 {c1: .18}")
-print(f"#define DRIFT2 {c2: .18}")
-print(f"#define KICK1  {d1: .18}")
-print(f"#define KICK2  {d2: .18}")
-*/
-#define DRIFT1  0.675603595979828886
-#define DRIFT2 -0.17560359597982883
-#define KICK1   1.35120719195965777
-#define KICK2  -1.70241438391931532
-
 struct elem {
   double Length;
   double *PolynomA;