Skip to content

Commit 8d628bf

Browse files
authored
Fix a regression bug in AtGetRingProperties (#701)
* fix missing 'cavpts' in ring parameters
1 parent dd325a4 commit 8d628bf

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

atmat/lattice/atGetRingProperties.m

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -74,26 +74,25 @@
7474
[show_all, varargin]=getflag(varargin, 'all');
7575
idx=atlocateparam(ring);
7676
if isempty(idx)
77-
% t1='Slow access to properties because there is no RingParam element.';
78-
% t2='Consider adding it with the command: ">> ring=atSetRingProperties(ring)".';
79-
% warning('AT:NoRingParam', '%s\n%s', t1, t2);
77+
t1='Slow access to properties because there is no RingParam element.';
78+
t2='Consider adding it with the command: ">> ring=atSetRingProperties(ring)".';
79+
warning('AT:NoRingParam', '%s\n%s', t1, t2);
8080
props=struct();
8181
else
8282
props=rmfield(ring{idx},{'Length','Class','PassMethod'});
8383
end
8484
if isempty(varargin)
85-
[props,~]=atparamscan(ring,props,'FamName','Energy','Periodicity',...
86-
'Particle','cell_harmnumber','cavpts');
87-
props.Particle=atparticle.loadobj(props.Particle);
88-
props.HarmNumber=props.Periodicity*props.cell_harmnumber;
85+
prmlist = {'FamName','Energy','Periodicity', 'Particle',...
86+
'cell_harmnumber', 'HarmNumber','cavpts'};
8987
if show_all
90-
prmlist={'beta', 'gamma', 'BRho', 'rf_frequency', 'rf_voltage', 'rf_timelag',...
91-
'mcf', 'slip_factor', 'radiation', 'is_6d', 'has_cavity',...
92-
'Circumference', 'revolution_frequency',...
93-
'cell_length', 'cell_rf_voltage', 'cell_revolution_frequency'};
94-
[~,prms]=atparamscan(ring,props,prmlist{:});
95-
cellfun(@setprop,prmlist,prms);
88+
prmlist = [prmlist {'beta', 'gamma', 'BRho', 'rf_frequency',...
89+
'rf_voltage', 'rf_timelag', 'mcf', 'slip_factor',...
90+
'radiation', 'is_6d', 'has_cavity', 'Circumference',...
91+
'revolution_frequency', 'cell_length', 'cell_rf_voltage',...
92+
'cell_revolution_frequency'}];
9693
end
94+
[~, prms] = atparamscan(ring, props, prmlist{:});
95+
cellfun(@setprop, prmlist, prms);
9796
varargout={props,idx};
9897
else
9998
[~,varargout]=atparamscan(ring,props,varargin{:});

0 commit comments

Comments
 (0)