Merge pull request #319 from atilaneves/fix-316

Fix #316 - run tests in private structs

Author: atilaneves

subpackages/runner/source/unit_threaded/runner/reflection.d

@@ -271,14 +271,7 @@ private TestData[] moduleUnitTests_(alias module_)() {
 
         foreach(member; __traits(allMembers, composite)) {
 
-            // isPrivate can't be used here. I don't know why.
-            static if(__traits(compiles, __traits(getProtection, __traits(getMember, module_, member))))
-                enum notPrivate = __traits(getProtection, __traits(getMember, module_, member)) != "private";
-            else
-                enum notPrivate = false;
-
             static if (
-                notPrivate &&
                 // If visibility of the member is deprecated, the next line still returns true
                 // and yet spills deprecation warning. If deprecation is turned into error,
                 // all works as intended.

tests/unit_threaded/ut/issues.d

@@ -357,3 +357,29 @@ else {
     const(int[]) arr;
     arr.shouldBeEmpty;
 }
+
+
+version(unitThreadedLight) {}
+else {
+
+    @("316")
+    @system unittest {
+
+        import unit_threaded.runner.factory: createTestCases;
+        import std.algorithm: find, canFind;
+        import std.array: front;
+
+        enum testModule = "unit_threaded.ut.modules.issue316";
+
+        const testData = allTestData!testModule;
+        auto tests = createTestCases(testData);
+
+        auto external = tests.find!(a => a.getPath.canFind("L4")).front;
+        // opCall returns an array of failures
+        external().length.should == 0;
+
+        auto internal = tests.find!(a => a.getPath.canFind("L9")).front;
+        // opCall returns an array of internalures
+        internal().length.should == 0;
+    }
+}

tests/unit_threaded/ut/modules/issue316.d

@@ -0,0 +1,11 @@
+module unit_threaded.ut.modules.issue316;
+
+
+unittest {
+    assert(true, "outside");
+}
+
+private struct PrivateStruct {
+    unittest {
+    }
+}