From 0d9d3657e42b5d1724faf10842285cc7fdca64c7 Mon Sep 17 00:00:00 2001 From: Christian Abella Date: Fri, 21 Feb 2025 14:13:22 -1000 Subject: [PATCH] AXON-144 fix default value on fail --- src/util/featureFlags/client.ts | 13 ++++++++----- src/util/featureFlags/features.ts | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/util/featureFlags/client.ts b/src/util/featureFlags/client.ts index 06fb2325..6cbee10e 100644 --- a/src/util/featureFlags/client.ts +++ b/src/util/featureFlags/client.ts @@ -67,15 +67,18 @@ export class FeatureFlagClient { } public static checkExperimentValue(experiment: string): any { - let gateValue: any = undefined; + let gateValue: any; + const experimentGate = ExperimentGates[experiment]; if (FeatureGates === null) { - console.warn('FeatureGates: FeatureGates is not initialized. Defaulting to Undefined'); + console.warn( + `FeatureGates: FeatureGates is not initialized. Returning default value: ${experimentGate.defaultValue}`, + ); } else { console.log(ExperimentGates[experiment]); gateValue = FeatureGates.getExperimentValue( - ExperimentGates[experiment].gate, - ExperimentGates[experiment].parameter, - ExperimentGates[experiment].defaultValue, + experimentGate.gate, + experimentGate.parameter, + experimentGate.defaultValue, ); } console.log(`ExperimentGateValue: ${experiment} -> ${gateValue}`); diff --git a/src/util/featureFlags/features.ts b/src/util/featureFlags/features.ts index 6beb509e..e073ef82 100644 --- a/src/util/featureFlags/features.ts +++ b/src/util/featureFlags/features.ts @@ -17,7 +17,7 @@ export const ExperimentGates: ExperimentGate = { [Experiments.NewAuthUIAA]: { gate: 'atlascode_new_auth_ui_aa', parameter: 'isEnabled', - defaultValue: `bruh`, + defaultValue: false, }, };