Skip to content

Commit 1066d7c

Browse files
committed
Added commit hash handling
1 parent 14d2417 commit 1066d7c

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

src/views/nodes/directoryNode.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { PRDirectory } from '../pullrequest/diffViewHelper';
33
import { AbstractBaseNode } from './abstractBaseNode';
44
import { PullRequestFilesNode } from './pullRequestFilesNode';
55
import { Container } from 'src/container';
6-
import { Logger } from 'src/logger';
76
import { PullRequest } from 'src/bitbucket/model';
87
import * as crypto from 'crypto';
98

@@ -13,6 +12,7 @@ export class DirectoryNode extends AbstractBaseNode {
1312
private directoryData: PRDirectory,
1413
private section: 'files' | 'commits' = 'files',
1514
private pr: PullRequest,
15+
private commitHash?: string,
1616
) {
1717
super();
1818
}
@@ -29,7 +29,7 @@ export class DirectoryNode extends AbstractBaseNode {
2929

3030
const dirId =
3131
this.section === 'commits'
32-
? `repo-${repoId}-pr-${prId}-section-${this.section}-commit-${this.pr.data.source.commitHash}-directory-${dirPath}`
32+
? `repo-${repoId}-pr-${prId}-section-${this.section}-commit-${this.commitHash}-directory-${dirPath}`
3333
: `repo-${repoId}-pr-${prId}-section-${this.section}-directory-${dirPath}`;
3434
return crypto.createHash('md5').update(dirId).digest('hex');
3535
}
@@ -56,10 +56,8 @@ export class DirectoryNode extends AbstractBaseNode {
5656

5757
try {
5858
this._isDirectClick = true;
59-
Logger.debug(`Setting directory ${this.directoryId} checked state to ${value}`);
6059
Container.checkboxStateManager.setChecked(this.directoryId, value);
6160

62-
Logger.debug('Propagating state to children');
6361
this.directoryData.files.forEach((file) => {
6462
const fileNode = new PullRequestFilesNode(file, this.section, this.pr);
6563
Container.checkboxStateManager.setChecked(fileNode.fileId, value);
@@ -106,8 +104,6 @@ export class DirectoryNode extends AbstractBaseNode {
106104
item.contextValue = `directory${allChecked ? '.checked' : ''}`;
107105
}
108106

109-
Logger.debug('directoryId', this.directoryId);
110-
111107
if (!this.isRootFilesDirectory) {
112108
item.id = this.directoryId;
113109
}

src/views/nodes/pullRequestFilesNode.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export class PullRequestFilesNode extends AbstractBaseNode {
1616
private diffViewData: DiffViewArgs,
1717
private section: 'files' | 'commits' = 'files',
1818
private pr: PullRequest,
19+
private commitHash?: string,
1920
) {
2021
super();
2122
}
@@ -27,7 +28,7 @@ export class PullRequestFilesNode extends AbstractBaseNode {
2728

2829
const fileId =
2930
this.section === 'commits'
30-
? `repo-${repoId}-pr-${this.pr.data.id}-section-${this.section}-commit-${this.pr.data.source.commitHash}-file-${this.diffViewData.fileDisplayData.fileDisplayName}-${this.diffViewData.latestFileContentHash}`
31+
? `repo-${repoId}-pr-${this.pr.data.id}-section-${this.section}-commit-${this.commitHash}-file-${this.diffViewData.fileDisplayData.fileDisplayName}-${this.diffViewData.latestFileContentHash}`
3132
: `repo-${repoId}-pr-${this.pr.data.id}-section-${this.section}-file-${this.diffViewData.fileDisplayData.fileDisplayName}-${this.diffViewData.latestFileContentHash}`;
3233
return crypto.createHash('md5').update(fileId).digest('hex');
3334
}

src/views/pullrequest/diffViewHelper.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ export async function getArgsForDiffView(
116116
const rhsFilePath = fileDiff.newPath;
117117

118118
let fileDisplayName = getFileNameFromPaths(lhsFilePath, rhsFilePath);
119-
Logger.debug('lhsFilePath', lhsFilePath, fileDisplayName);
120119
const comments: Comment[][] = [];
121120
const commentsMap = getInlineComments(allComments.data);
122121

@@ -305,10 +304,10 @@ export async function createFileChangesNodes(
305304

306305
const directoryNodes: DirectoryNode[] = Array.from(
307306
rootDirectory.subdirs.values(),
308-
(subdir) => new DirectoryNode(subdir, section, pr),
307+
(subdir) => new DirectoryNode(subdir, section, pr, commitRange?.rhs),
309308
);
310309
const childNodes: AbstractBaseNode[] = rootDirectory.files.map(
311-
(diffViewArg) => new PullRequestFilesNode(diffViewArg, section, pr),
310+
(diffViewArg) => new PullRequestFilesNode(diffViewArg, section, pr, commitRange?.rhs),
312311
);
313312
return childNodes.concat(directoryNodes);
314313
}

0 commit comments

Comments
 (0)