Add eslint rule: Require let or const instead of var

marcomura · marcomura · commit 4cb18dee4002 · 2025-02-14T10:38:58.000-08:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -54,11 +54,12 @@ module.exports = {
             },
         ],
         'brace-style': 'off',
+        'no-throw-literal': 'error',
+        'no-var': 'error',
         curly: 'error',
         eqeqeq: ['error', 'always'],
         semi: 'off',
         '@stylistic/js/semi': ['error', 'always'],
-        'no-throw-literal': 'error',
     },
     settings: {
         react: {
diff --git a/src/analytics.ts b/src/analytics.ts
@@ -623,7 +623,7 @@ async function tenantTrackEvent(
 }
 
 function event(action: string, actionSubject: string, attributes: any): any {
-    var event = {
+    let event = {
         origin: 'desktop',
         platform: AnalyticsPlatform.for(process.platform),
         action: action,
diff --git a/src/jira/jira-client/providers.ts b/src/jira/jira-client/providers.ts
@@ -14,7 +14,7 @@ import { Container } from '../../container';
 import { Resources } from '../../resources';
 import { ConnectionTimeout } from '../../util/time';
 
-var tunnel = require('tunnel');
+let tunnel = require('tunnel');
 
 export function getAxiosInstance(): AxiosInstance {
     const instance = axios.create({
diff --git a/src/jira/newIssueMonitor.ts b/src/jira/newIssueMonitor.ts
@@ -93,7 +93,7 @@ export class NewIssueMonitor {
         }
 
         const issueNames = newIssues.map((issue) => `[${issue.key}] "${issue.summary}"`);
-        var message = '';
+        let message = '';
         if (newIssues.length === 1) {
             message = `${issueNames[0]} added to explorer`;
         } else if (newIssues.length <= 3) {
diff --git a/src/lib/.eslintrc.js b/src/lib/.eslintrc.js
@@ -1,5 +1,6 @@
 module.exports = {
     rules: {
+        'no-var': 'error',
         'no-restricted-imports': [
             'error',
             {
diff --git a/src/lib/webview/controller/config/configWebviewController.ts b/src/lib/webview/controller/config/configWebviewController.ts
@@ -119,7 +119,7 @@ export class ConfigWebviewController implements WebviewController<SectionChangeM
                 break;
             }
             case ConfigActionType.Login: {
-                var isCloud = true;
+                let isCloud = true;
                 if (isBasicAuthInfo(msg.authInfo) || isPATAuthInfo(msg.authInfo)) {
                     isCloud = false;
                     try {
diff --git a/src/lib/webview/controller/onboarding/onboardingWebviewController.ts b/src/lib/webview/controller/onboarding/onboardingWebviewController.ts
@@ -94,7 +94,7 @@ export class OnboardingWebviewController implements WebviewController<SectionCha
                 break;
             }
             case OnboardingActionType.Login: {
-                var isCloud = true;
+                let isCloud = true;
                 if (isBasicAuthInfo(msg.authInfo)) {
                     isCloud = false;
                     try {
diff --git a/src/pipelines/pipelines.ts b/src/pipelines/pipelines.ts
@@ -243,8 +243,8 @@ export class PipelineApiImpl {
     }
 
     cleanPipelineData(site: BitbucketSite, pipeline: any): Pipeline {
-        var name = undefined;
-        var avatar = undefined;
+        let name = undefined;
+        let avatar = undefined;
         if (pipeline.creator) {
             name = pipeline.creator.display_name;
             if (pipeline.creator.links && pipeline.creator.links.avatar) {
diff --git a/src/pipelines/yaml/pipelinesYamlHelper.ts b/src/pipelines/yaml/pipelinesYamlHelper.ts
@@ -29,7 +29,7 @@ async function addPipelinesSchemaToConfigAtScope(
         newValue = Object.assign({}, valueAtScope);
     }
     Object.keys(newValue).forEach((configKey) => {
-        var configValue = newValue[configKey];
+        let configValue = newValue[configKey];
         if (value === configValue) {
             delete newValue[configKey];
         }
diff --git a/src/react/.eslintrc.js b/src/react/.eslintrc.js
@@ -1,5 +1,6 @@
 module.exports = {
     rules: {
+        'no-var': 'error',
         'no-restricted-imports': [
             'error',
             {
diff --git a/src/react/atlascode/bbissue/bitbucketIssueController.ts b/src/react/atlascode/bbissue/bitbucketIssueController.ts
@@ -218,7 +218,7 @@ export function useBitbucketIssueController(): [BitbucketIssueState, BitbucketIs
             return new Promise<User[]>((resolve, reject) => {
                 (async () => {
                     try {
-                        var abortKey: string = '';
+                        let abortKey: string = '';
 
                         if (abortSignal) {
                             abortKey = v4();
diff --git a/src/react/atlascode/common/editor/MarkdownEditor.tsx b/src/react/atlascode/common/editor/MarkdownEditor.tsx
@@ -80,7 +80,7 @@ const buildInputRules = (schema: any) => {
     return rules;
 };
 
-var schema = new Schema({
+let schema = new Schema({
     nodes: addMentionNodes(markdownSchema.spec.nodes),
     marks: markdownSchema.spec.marks,
 });
@@ -105,7 +105,7 @@ const mdParser = new MarkdownParser(schema, defaultMarkdownParser.tokenizer, {
  * IMPORTANT: outer div's "suggestion-item-list" class is mandatory. The plugin uses this class for querying.
  * IMPORTANT: inner div's "suggestion-item" class is mandatory too for the same reasons
  */
-var getMentionSuggestionsHTML = (items: any[]) =>
+let getMentionSuggestionsHTML = (items: any[]) =>
     '<div class="suggestion-item-list">' +
     items.map((i) => '<div class="suggestion-item">' + i.name + '</div>').join('') +
     '</div>';
diff --git a/src/react/atlascode/config/configController.ts b/src/react/atlascode/config/configController.ts
@@ -356,7 +356,7 @@ export function useConfigController(): [ConfigState, ConfigControllerApi] {
             return new Promise<Suggestion[]>((resolve, reject) => {
                 (async () => {
                     try {
-                        var abortKey: string = '';
+                        let abortKey: string = '';
 
                         if (abortSignal) {
                             abortKey = v4();
@@ -402,7 +402,7 @@ export function useConfigController(): [ConfigState, ConfigControllerApi] {
             return new Promise<FilterSearchResults>((resolve, reject) => {
                 (async () => {
                     try {
-                        var abortKey: string = '';
+                        let abortKey: string = '';
 
                         if (abortSignal) {
                             abortKey = v4();
@@ -442,7 +442,7 @@ export function useConfigController(): [ConfigState, ConfigControllerApi] {
             return new Promise<JQLErrors>((resolve, reject) => {
                 (async () => {
                     try {
-                        var abortKey: string = '';
+                        let abortKey: string = '';
 
                         if (abortSignal) {
                             abortKey = v4();
diff --git a/src/react/atlascode/config/jira/jql/JQLEditDialog.tsx b/src/react/atlascode/config/jira/jql/JQLEditDialog.tsx
@@ -89,11 +89,11 @@ export const JQLEditDialog: React.FunctionComponent<JQLEditDialogProps> = ({
 
     const handleSave = useCallback(
         (data: FormFields) => {
-            var entry: JQLEntry = jqlEntry
+            let entry: JQLEntry = jqlEntry
                 ? jqlEntry
                 : { id: v4(), siteId: '', name: '', query: '', enabled: true, monitor: true };
 
-            var newEntry = Object.assign({}, entry, {
+            let newEntry = Object.assign({}, entry, {
                 siteId: data.site,
                 name: data.name,
                 // [VSCODE-1282] Having to revert to jqlEntry as there's a bug with how default values are handled currently
@@ -113,7 +113,7 @@ export const JQLEditDialog: React.FunctionComponent<JQLEditDialogProps> = ({
 
     useEffect(() => {
         if (jqlEntry) {
-            var foundSite = sites.find((s) => s.id === jqlEntry.siteId);
+            let foundSite = sites.find((s) => s.id === jqlEntry.siteId);
             if (foundSite) {
                 setSite(foundSite);
             }
diff --git a/src/react/atlascode/pullrequest/createPullRequestController.ts b/src/react/atlascode/pullrequest/createPullRequestController.ts
@@ -154,7 +154,7 @@ export function useCreatePullRequestController(): [CreatePullRequestState, Creat
             return new Promise<User[]>((resolve, reject) => {
                 (async () => {
                     try {
-                        var abortKey: string = '';
+                        let abortKey: string = '';
 
                         if (abortSignal) {
                             abortKey = v4();
diff --git a/src/react/atlascode/pullrequest/pullRequestDetailsController.ts b/src/react/atlascode/pullrequest/pullRequestDetailsController.ts
@@ -376,7 +376,7 @@ export function usePullRequestDetailsController(): [PullRequestDetailsState, Pul
             return new Promise<User[]>((resolve, reject) => {
                 (async () => {
                     try {
-                        var abortKey: string = '';
+                        let abortKey: string = '';
 
                         if (abortSignal) {
                             abortKey = v4();
diff --git a/src/react/index-dev.tsx b/src/react/index-dev.tsx
@@ -12,7 +12,7 @@ import { createVSCodeTheme } from './vscode/theme/vscodeTheme';
 
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
-declare var __webpack_public_path__: string;
+declare let __webpack_public_path__: string;
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {
@@ -71,7 +71,7 @@ class VsCodeApi {
         // most important part - incoming messages
         this.conn.onmessage = function (message): void {
             try {
-                var json = JSON.parse(message.data);
+                let json = JSON.parse(message.data);
                 window.postMessage(json.data, '*');
             } catch (e) {
                 console.error('Invalid JSON: ', message.data);
diff --git a/src/react/index.tsx b/src/react/index.tsx
@@ -13,7 +13,7 @@ import { createVSCodeTheme } from './vscode/theme/vscodeTheme';
 
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
-declare var __webpack_public_path__: string;
+declare let __webpack_public_path__: string;
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {
diff --git a/src/views/pipelines/Helpers.ts b/src/views/pipelines/Helpers.ts
@@ -45,7 +45,7 @@ export function descriptionForState(
         pipeline_state_completed_stopped: 'has been stopped',
     };
 
-    var words = 'has done something';
+    let words = 'has done something';
     switch (result.state!.type) {
         case 'pipeline_state_completed':
             words = descriptionForResult[result.state!.result!.type];
diff --git a/src/views/pipelines/PipelinesMonitor.ts b/src/views/pipelines/PipelinesMonitor.ts
@@ -15,7 +15,7 @@ export class PipelinesMonitor implements BitbucketActivityMonitor {
         if (!Container.config.bitbucket.pipelines.monitorEnabled) {
             return;
         }
-        for (var i = 0; i < this._repositories.length; i++) {
+        for (let i = 0; i < this._repositories.length; i++) {
             const wsRepo = this._repositories[i];
             const previousResults = this._previousResults[wsRepo.rootUri];
 
@@ -30,7 +30,7 @@ export class PipelinesMonitor implements BitbucketActivityMonitor {
             }
 
             bbApi.pipelines.getRecentActivity(site).then((newResults) => {
-                var diffs = this.diffResults(previousResults, newResults);
+                let diffs = this.diffResults(previousResults, newResults);
                 diffs = diffs.filter((p) => this.shouldDisplayTarget(p.target));
                 const buttonText = diffs.length === 1 ? 'View' : 'View Pipeline Explorer';
                 if (diffs.length > 0) {
@@ -61,8 +61,8 @@ export class PipelinesMonitor implements BitbucketActivityMonitor {
         const changes: Pipeline[] = [];
         const previousLength = oldResults.length;
         const newLength = newResults.length;
-        var i = 0;
-        var j = 0;
+        let i = 0;
+        let j = 0;
         while (true) {
             if (i === previousLength || j === newLength) {
                 return changes;
diff --git a/src/webview/bbIssue/vscBitbucketIssueActionApi.ts b/src/webview/bbIssue/vscBitbucketIssueActionApi.ts
@@ -48,7 +48,7 @@ export class VSCBitbucketIssueActionApi implements BitbucketIssueActionApi {
     async fetchUsers(issue: BitbucketIssue, query: string, abortKey?: string): Promise<User[]> {
         const bbApi = await clientForSite(issue.site);
 
-        var cancelToken: CancelToken | undefined = undefined;
+        let cancelToken: CancelToken | undefined = undefined;
 
         if (abortKey) {
             const signal: CancelTokenSource = axios.CancelToken.source();
diff --git a/src/webview/config/vscConfigActionApi.ts b/src/webview/config/vscConfigActionApi.ts
@@ -66,7 +66,7 @@ export class VSCConfigActionApi implements ConfigActionApi {
     ): Promise<AutocompleteSuggestion[]> {
         const client = await Container.clientManager.jiraClient(site);
 
-        var cancelToken: CancelToken | undefined = undefined;
+        let cancelToken: CancelToken | undefined = undefined;
 
         if (abortKey) {
             const signal: CancelTokenSource = axios.CancelToken.source();
@@ -86,7 +86,7 @@ export class VSCConfigActionApi implements ConfigActionApi {
     ): Promise<FilterSearchResults> {
         const client = await Container.clientManager.jiraClient(site);
 
-        var cancelToken: CancelToken | undefined = undefined;
+        let cancelToken: CancelToken | undefined = undefined;
 
         if (abortKey) {
             const signal: CancelTokenSource = axios.CancelToken.source();
@@ -100,7 +100,7 @@ export class VSCConfigActionApi implements ConfigActionApi {
     public async validateJql(site: DetailedSiteInfo, jql: string, abortKey?: string): Promise<JQLErrors> {
         const client = await Container.clientManager.jiraClient(site);
 
-        var cancelToken: CancelToken | undefined = undefined;
+        let cancelToken: CancelToken | undefined = undefined;
 
         if (abortKey) {
             const signal: CancelTokenSource = axios.CancelToken.source();
diff --git a/src/webview/pullrequest/vscCreatePullRequestActionImpl.ts b/src/webview/pullrequest/vscCreatePullRequestActionImpl.ts
@@ -85,7 +85,7 @@ export class VSCCreatePullRequestActionApi implements CreatePullRequestActionApi
     async fetchUsers(site: BitbucketSite, query: string, abortKey?: string | undefined): Promise<User[]> {
         const client = await Container.clientManager.bbClient(site.details);
 
-        var cancelToken: CancelToken | undefined = undefined;
+        let cancelToken: CancelToken | undefined = undefined;
 
         if (abortKey) {
             const signal: CancelTokenSource = axios.CancelToken.source();
diff --git a/src/webview/pullrequest/vscPullRequestDetailsActionApi.ts b/src/webview/pullrequest/vscPullRequestDetailsActionApi.ts
@@ -56,7 +56,7 @@ export class VSCPullRequestDetailsActionApi implements PullRequestDetailsActionA
     async fetchUsers(site: BitbucketSite, query: string, abortKey?: string | undefined): Promise<User[]> {
         const client = await Container.clientManager.bbClient(site.details);
 
-        var cancelToken: CancelToken | undefined = undefined;
+        let cancelToken: CancelToken | undefined = undefined;
 
         if (abortKey) {
             const signal: CancelTokenSource = axios.CancelToken.source();
diff --git a/src/webviews/components/index-dev.tsx b/src/webviews/components/index-dev.tsx
@@ -6,7 +6,7 @@ import './App.css';
 
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
-declare var __webpack_public_path__: string;
+declare let __webpack_public_path__: string;
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {
@@ -33,7 +33,7 @@ class VsCodeApi {
         // most important part - incoming messages
         this.conn.onmessage = function (message) {
             try {
-                var json = JSON.parse(message.data);
+                let json = JSON.parse(message.data);
                 window.postMessage(json.data, '*');
             } catch (e) {
                 return;
diff --git a/src/webviews/components/index.tsx b/src/webviews/components/index.tsx
@@ -4,7 +4,7 @@ import './App.css';
 
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
-declare var __webpack_public_path__: string;
+declare let __webpack_public_path__: string;
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {
diff --git a/src/ws.ts b/src/ws.ts
@@ -27,9 +27,9 @@ export class UIWebsocket implements Disposable {
 
         this._ws.on('request', function (request) {
             console.log(new Date() + ` Connection from origin ${request.origin}.`);
-            var connection = request.accept(undefined, request.origin);
+            let connection = request.accept(undefined, request.origin);
             // we need to know client index to remove them on 'close' event
-            var index = clients.push(connection) - 1;
+            let index = clients.push(connection) - 1;
             console.log(new Date() + ' Connection accepted.');
 
             // user sent some message
@@ -54,7 +54,7 @@ export class UIWebsocket implements Disposable {
     }
 
     public send(message: any) {
-        var json = JSON.stringify({ type: 'message', data: message });
+        let json = JSON.stringify({ type: 'message', data: message });
         this._clients.forEach((client) => {
             client.sendUTF(json);
         });

Original file line number	Diff line number	Diff line change
`@@ -623,7 +623,7 @@ async function tenantTrackEvent(`
`623`	`623`	`}`
`624`	`624`
`625`	`625`	`function event(action: string, actionSubject: string, attributes: any): any {`
`626`		`- var event = {`
	`626`	`+ let event = {`
`627`	`627`	`origin: 'desktop',`
`628`	`628`	`platform: AnalyticsPlatform.for(process.platform),`
`629`	`629`	`action: action,`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ export class NewIssueMonitor {`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	const issueNames = newIssues.map((issue) => `[${issue.key}] "${issue.summary}"`);
`96`		`- var message = '';`
	`96`	`+ let message = '';`
`97`	`97`	`if (newIssues.length === 1) {`
`98`	`98`	message = `${issueNames[0]} added to explorer`;
`99`	`99`	`} else if (newIssues.length <= 3) {`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`module.exports = {`
`2`	`2`	`rules: {`
	`3`	`+ 'no-var': 'error',`
`3`	`4`	`'no-restricted-imports': [`
`4`	`5`	`'error',`
`5`	`6`	`{`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ export class ConfigWebviewController implements WebviewController<SectionChangeM`
`119`	`119`	`break;`
`120`	`120`	`}`
`121`	`121`	`case ConfigActionType.Login: {`
`122`		`- var isCloud = true;`
	`122`	`+ let isCloud = true;`
`123`	`123`	`if (isBasicAuthInfo(msg.authInfo) \|\| isPATAuthInfo(msg.authInfo)) {`
`124`	`124`	`isCloud = false;`
`125`	`125`	`try {`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ export class OnboardingWebviewController implements WebviewController<SectionCha`
`94`	`94`	`break;`
`95`	`95`	`}`
`96`	`96`	`case OnboardingActionType.Login: {`
`97`		`- var isCloud = true;`
	`97`	`+ let isCloud = true;`
`98`	`98`	`if (isBasicAuthInfo(msg.authInfo)) {`
`99`	`99`	`isCloud = false;`
`100`	`100`	`try {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ async function addPipelinesSchemaToConfigAtScope(`
`29`	`29`	`newValue = Object.assign({}, valueAtScope);`
`30`	`30`	`}`
`31`	`31`	`Object.keys(newValue).forEach((configKey) => {`
`32`		`- var configValue = newValue[configKey];`
	`32`	`+ let configValue = newValue[configKey];`
`33`	`33`	`if (value === configValue) {`
`34`	`34`	`delete newValue[configKey];`
`35`	`35`	`}`