From 5b9a5f52bd3acd903b0a6f4cbeb6b095c69670cc Mon Sep 17 00:00:00 2001 From: Bryan Wieger Date: Wed, 12 Feb 2025 21:28:51 -0800 Subject: [PATCH] refactor --- src/bitbucket/bitbucket-server/pullRequests.ts | 4 ++-- src/bitbucket/httpClient.ts | 12 ------------ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/bitbucket/bitbucket-server/pullRequests.ts b/src/bitbucket/bitbucket-server/pullRequests.ts index 9fc94464..344b812c 100644 --- a/src/bitbucket/bitbucket-server/pullRequests.ts +++ b/src/bitbucket/bitbucket-server/pullRequests.ts @@ -6,7 +6,7 @@ import { CacheMap } from '../../util/cachemap'; import { Time } from '../../util/time'; import { getFileNameFromPaths } from '../../views/pullrequest/diffViewHelper'; import { clientForSite } from '../bbUtils'; -import { IHTTPClient } from '../httpClient'; +import { HTTPClient } from '../httpClient'; import { ApprovalStatus, BitbucketSite, @@ -32,7 +32,7 @@ export class ServerPullRequestApi implements PullRequestApi { private defaultReviewersCache: CacheMap = new CacheMap(); private fileContentCache: CacheMap = new CacheMap(); - constructor(private client: IHTTPClient) {} + constructor(private client: HTTPClient) {} async getList(workspaceRepo: WorkspaceRepo, queryParams?: any): Promise { const site = workspaceRepo.mainSiteRemote.site; diff --git a/src/bitbucket/httpClient.ts b/src/bitbucket/httpClient.ts index 1f2ee56f..dfb9beff 100644 --- a/src/bitbucket/httpClient.ts +++ b/src/bitbucket/httpClient.ts @@ -11,18 +11,6 @@ export interface RequestRange { end: number; } -export interface IHTTPClient { - getUrl(url: string, cancelToken?: CancelToken): Promise; - get(urlSlug: string, queryParams?: any, cancelToken?: CancelToken): Promise; - getRaw(urlSlug: string, queryParams?: any): Promise; - getArrayBuffer(urlSlug: string, queryParams?: any): Promise; - getOctetStream(urlSlug: string, range?: RequestRange, queryParams?: any): Promise; - post(urlSlug: string, body: any, queryParams?: any): Promise; - put(urlSlug: string, body: any, queryParams?: any): Promise; - delete(urlSlug: string, body: any, queryParams?: any): Promise; - generateUrl(urlSlug: string, queryParams?: any): string; -} - export class HTTPClient { private transport: AxiosInstance;