From 5c162710c17b362c25b38895fc27f1ad94fac8a0 Mon Sep 17 00:00:00 2001
From: Christian Abella <cabella@atlassian.com>
Date: Fri, 14 Feb 2025 17:36:56 -1000
Subject: [PATCH] AXON-130: refactor login action message flow to include
 better error handling and analytic posting

---
 .../onboarding/onboardingWebviewController.ts | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/lib/webview/controller/onboarding/onboardingWebviewController.ts b/src/lib/webview/controller/onboarding/onboardingWebviewController.ts
index 31cd5c26..cc084455 100644
--- a/src/lib/webview/controller/onboarding/onboardingWebviewController.ts
+++ b/src/lib/webview/controller/onboarding/onboardingWebviewController.ts
@@ -95,23 +95,23 @@ export class OnboardingWebviewController implements WebviewController<SectionCha
             }
             case OnboardingActionType.Login: {
                 let isCloud = true;
-                if (isBasicAuthInfo(msg.authInfo)) {
-                    isCloud = false;
-                    try {
+                this._analytics.fireAuthenticateButtonEvent(id, msg.siteInfo, isCloud);
+                try {
+                    if (isBasicAuthInfo(msg.authInfo)) {
+                        isCloud = false;
                         await this._api.authenticateServer(msg.siteInfo, msg.authInfo);
-                    } catch (e) {
-                        const err = new Error(`Authentication error: ${e}`);
-                        this._logger.error(err);
-                        this.postMessage({
-                            type: CommonMessageType.Error,
-                            reason: formatError(e, 'Authentication error'),
-                        });
+                    } else {
+                        await this._api.authenticateCloud(msg.siteInfo, this._onboardingUrl);
                     }
-                } else {
-                    await this._api.authenticateCloud(msg.siteInfo, this._onboardingUrl);
+                    this.postMessage({ type: OnboardingMessageType.LoginResponse });
+                } catch (e) {
+                    const env = isCloud ? 'cloud' : 'server';
+                    this._logger.error(new Error(`${env} onboarding authentication error: ${e}`));
+                    this.postMessage({
+                        type: CommonMessageType.Error,
+                        reason: formatError(e, `${env} onboarding authentication error`),
+                    });
                 }
-                this.postMessage({ type: OnboardingMessageType.LoginResponse });
-                this._analytics.fireAuthenticateButtonEvent(id, msg.siteInfo, isCloud);
                 break;
             }
             case OnboardingActionType.SaveSettings: {