AXON-114 : remove feature flag for RDE Auth (#117)

* pause work * remove feature flag * cleanup code * fix pipeline failure * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
atlassian · Feb 14, 2025 · 9fe90a5 · 9fe90a5
1 parent 66cac1a
commit 9fe90a5
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,14 @@
+## What's new in 3.4.6
+
+### Features
+
+- Cleaned up feature flag for Jira Cloud authentication from Remote Development Environments
+- Placed code for Auth UI experiment. Still needs additional work before we turn this on.
+
+### Engineeering Excellence 
+- Cleaned up some of our code with new lint rules
+- Added some unit tests around authentication 
+
 ## What's new in 3.4.5
 
 ### Bug Fixes

diff --git a/src/react/atlascode/config/auth/SiteAuthenticator.tsx b/src/react/atlascode/config/auth/SiteAuthenticator.tsx
@@ -7,8 +7,6 @@ import DomainIcon from '@material-ui/icons/Domain';
 import { Product, ProductJira } from '../../../../atlclients/authInfo';
 import { SiteList } from './SiteList';
 import { SiteWithAuthInfo } from '../../../../lib/ipc/toUI/config';
-import { Features } from 'src/util/featureFlags';
-import { CommonMessageType } from 'src/lib/ipc/toUI/common';
 
 type SiteAuthenticatorProps = {
     product: Product;
@@ -30,24 +28,10 @@ export const SiteAuthenticator: React.FunctionComponent<SiteAuthenticatorProps>
             [authDialogController, product],
         );
 
-        const [useNewAuth, setUseNewAuth] = React.useState(false);
-        React.useEffect(() => {
-            window.addEventListener('message', (event) => {
-                const message = event.data;
-                if (message.command === CommonMessageType.UpdateFeatureFlags) {
-                    const featureValue = message.featureFlags[Features.EnableRemoteAuthentication];
-                    console.log(
-                        `FeatureGates: received by SiteAuthenticator - ${Features.EnableRemoteAuthentication} -> ${featureValue}`,
-                    );
-                    setUseNewAuth(featureValue);
-                }
-            });
-        }, []);
-
         return (
             <Box flexGrow={1}>
                 <Grid container direction="column" spacing={2}>
-                    {useNewAuth && product.key === ProductJira.key ? (
+                    {product.key === ProductJira.key ? (
                         <AuthContainer
                             isRemote={isRemote}
                             product={product}

diff --git a/src/util/featureFlags/features.ts b/src/util/featureFlags/features.ts
@@ -1,5 +1,4 @@
 export enum Features {
-    EnableRemoteAuthentication = 'atlascode-enable-remote-authentication',
     EnableNewUriHandler = 'atlascode-enable-new-uri-handler',
     EnableAuthUI = 'atlascode-enable-auth-ui',
 }