File tree Expand file tree Collapse file tree 3 files changed +12
-18
lines changed
react/atlascode/config/auth Expand file tree Collapse file tree 3 files changed +12
-18
lines changed Original file line number Diff line number Diff line change
1
+ ## What's new in 3.4.6
2
+
3
+ ### Features
4
+
5
+ - Cleaned up feature flag for Jira Cloud authentication from Remote Development Environments
6
+ - Placed code for Auth UI experiment. Still needs additional work before we turn this on.
7
+
8
+ ### Engineeering Excellence
9
+ - Cleaned up some of our code with new lint rules
10
+ - Added some unit tests around authentication
11
+
1
12
## What's new in 3.4.5
2
13
3
14
### Bug Fixes
Original file line number Diff line number Diff line change @@ -7,8 +7,6 @@ import DomainIcon from '@material-ui/icons/Domain';
7
7
import { Product , ProductJira } from '../../../../atlclients/authInfo' ;
8
8
import { SiteList } from './SiteList' ;
9
9
import { SiteWithAuthInfo } from '../../../../lib/ipc/toUI/config' ;
10
- import { Features } from 'src/util/featureFlags' ;
11
- import { CommonMessageType } from 'src/lib/ipc/toUI/common' ;
12
10
13
11
type SiteAuthenticatorProps = {
14
12
product : Product ;
@@ -30,24 +28,10 @@ export const SiteAuthenticator: React.FunctionComponent<SiteAuthenticatorProps>
30
28
[ authDialogController , product ] ,
31
29
) ;
32
30
33
- const [ useNewAuth , setUseNewAuth ] = React . useState ( false ) ;
34
- React . useEffect ( ( ) => {
35
- window . addEventListener ( 'message' , ( event ) => {
36
- const message = event . data ;
37
- if ( message . command === CommonMessageType . UpdateFeatureFlags ) {
38
- const featureValue = message . featureFlags [ Features . EnableRemoteAuthentication ] ;
39
- console . log (
40
- `FeatureGates: received by SiteAuthenticator - ${ Features . EnableRemoteAuthentication } -> ${ featureValue } ` ,
41
- ) ;
42
- setUseNewAuth ( featureValue ) ;
43
- }
44
- } ) ;
45
- } , [ ] ) ;
46
-
47
31
return (
48
32
< Box flexGrow = { 1 } >
49
33
< Grid container direction = "column" spacing = { 2 } >
50
- { useNewAuth && product . key === ProductJira . key ? (
34
+ { product . key === ProductJira . key ? (
51
35
< AuthContainer
52
36
isRemote = { isRemote }
53
37
product = { product }
Original file line number Diff line number Diff line change 1
1
export enum Features {
2
- EnableRemoteAuthentication = 'atlascode-enable-remote-authentication' ,
3
2
EnableNewUriHandler = 'atlascode-enable-new-uri-handler' ,
4
3
EnableAuthUI = 'atlascode-enable-auth-ui' ,
5
4
}
You can’t perform that action at this time.
0 commit comments