Skip to content

Commit 9fe90a5

Browse files
AXON-114 : remove feature flag for RDE Auth (#117)
* pause work * remove feature flag * cleanup code * fix pipeline failure * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md
1 parent 66cac1a commit 9fe90a5

File tree

3 files changed

+12
-18
lines changed

3 files changed

+12
-18
lines changed

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
## What's new in 3.4.6
2+
3+
### Features
4+
5+
- Cleaned up feature flag for Jira Cloud authentication from Remote Development Environments
6+
- Placed code for Auth UI experiment. Still needs additional work before we turn this on.
7+
8+
### Engineeering Excellence
9+
- Cleaned up some of our code with new lint rules
10+
- Added some unit tests around authentication
11+
112
## What's new in 3.4.5
213

314
### Bug Fixes

src/react/atlascode/config/auth/SiteAuthenticator.tsx

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import DomainIcon from '@material-ui/icons/Domain';
77
import { Product, ProductJira } from '../../../../atlclients/authInfo';
88
import { SiteList } from './SiteList';
99
import { SiteWithAuthInfo } from '../../../../lib/ipc/toUI/config';
10-
import { Features } from 'src/util/featureFlags';
11-
import { CommonMessageType } from 'src/lib/ipc/toUI/common';
1210

1311
type SiteAuthenticatorProps = {
1412
product: Product;
@@ -30,24 +28,10 @@ export const SiteAuthenticator: React.FunctionComponent<SiteAuthenticatorProps>
3028
[authDialogController, product],
3129
);
3230

33-
const [useNewAuth, setUseNewAuth] = React.useState(false);
34-
React.useEffect(() => {
35-
window.addEventListener('message', (event) => {
36-
const message = event.data;
37-
if (message.command === CommonMessageType.UpdateFeatureFlags) {
38-
const featureValue = message.featureFlags[Features.EnableRemoteAuthentication];
39-
console.log(
40-
`FeatureGates: received by SiteAuthenticator - ${Features.EnableRemoteAuthentication} -> ${featureValue}`,
41-
);
42-
setUseNewAuth(featureValue);
43-
}
44-
});
45-
}, []);
46-
4731
return (
4832
<Box flexGrow={1}>
4933
<Grid container direction="column" spacing={2}>
50-
{useNewAuth && product.key === ProductJira.key ? (
34+
{product.key === ProductJira.key ? (
5135
<AuthContainer
5236
isRemote={isRemote}
5337
product={product}

src/util/featureFlags/features.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
export enum Features {
2-
EnableRemoteAuthentication = 'atlascode-enable-remote-authentication',
32
EnableNewUriHandler = 'atlascode-enable-new-uri-handler',
43
EnableAuthUI = 'atlascode-enable-auth-ui',
54
}

0 commit comments

Comments
 (0)