From 9fe90a50cf0fb73afa0b9c58ab12d43676c8a1bb Mon Sep 17 00:00:00 2001
From: bwieger-atlassian-com <bwieger@atlassian.com>
Date: Fri, 14 Feb 2025 15:56:22 -0800
Subject: [PATCH] AXON-114 : remove feature flag for RDE Auth  (#117)

* pause work

* remove feature flag

* cleanup code

* fix pipeline failure

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md
---
 CHANGELOG.md                                   | 11 +++++++++++
 .../config/auth/SiteAuthenticator.tsx          | 18 +-----------------
 src/util/featureFlags/features.ts              |  1 -
 3 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 24269094..ad746ac5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,14 @@
+## What's new in 3.4.6
+
+### Features
+
+- Cleaned up feature flag for Jira Cloud authentication from Remote Development Environments
+- Placed code for Auth UI experiment. Still needs additional work before we turn this on.
+
+### Engineeering Excellence 
+- Cleaned up some of our code with new lint rules
+- Added some unit tests around authentication 
+
 ## What's new in 3.4.5
 
 ### Bug Fixes
diff --git a/src/react/atlascode/config/auth/SiteAuthenticator.tsx b/src/react/atlascode/config/auth/SiteAuthenticator.tsx
index 2bf241d5..e0839c8d 100644
--- a/src/react/atlascode/config/auth/SiteAuthenticator.tsx
+++ b/src/react/atlascode/config/auth/SiteAuthenticator.tsx
@@ -7,8 +7,6 @@ import DomainIcon from '@material-ui/icons/Domain';
 import { Product, ProductJira } from '../../../../atlclients/authInfo';
 import { SiteList } from './SiteList';
 import { SiteWithAuthInfo } from '../../../../lib/ipc/toUI/config';
-import { Features } from 'src/util/featureFlags';
-import { CommonMessageType } from 'src/lib/ipc/toUI/common';
 
 type SiteAuthenticatorProps = {
     product: Product;
@@ -30,24 +28,10 @@ export const SiteAuthenticator: React.FunctionComponent<SiteAuthenticatorProps>
             [authDialogController, product],
         );
 
-        const [useNewAuth, setUseNewAuth] = React.useState(false);
-        React.useEffect(() => {
-            window.addEventListener('message', (event) => {
-                const message = event.data;
-                if (message.command === CommonMessageType.UpdateFeatureFlags) {
-                    const featureValue = message.featureFlags[Features.EnableRemoteAuthentication];
-                    console.log(
-                        `FeatureGates: received by SiteAuthenticator - ${Features.EnableRemoteAuthentication} -> ${featureValue}`,
-                    );
-                    setUseNewAuth(featureValue);
-                }
-            });
-        }, []);
-
         return (
             <Box flexGrow={1}>
                 <Grid container direction="column" spacing={2}>
-                    {useNewAuth && product.key === ProductJira.key ? (
+                    {product.key === ProductJira.key ? (
                         <AuthContainer
                             isRemote={isRemote}
                             product={product}
diff --git a/src/util/featureFlags/features.ts b/src/util/featureFlags/features.ts
index 06c9b576..5e17c856 100644
--- a/src/util/featureFlags/features.ts
+++ b/src/util/featureFlags/features.ts
@@ -1,5 +1,4 @@
 export enum Features {
-    EnableRemoteAuthentication = 'atlascode-enable-remote-authentication',
     EnableNewUriHandler = 'atlascode-enable-new-uri-handler',
     EnableAuthUI = 'atlascode-enable-auth-ui',
 }