Add eslint rule: Disallow unused variables (#118)

Author: marcomura

.eslintrc.js

@@ -53,6 +53,12 @@ module.exports = {
                 ],
             },
         ],
+        "no-unused-vars": ["error", {
+            "vars": "all",
+            "args": "none",
+            "caughtErrors": "all",
+            "ignoreRestSiblings": false,
+        }],        
         'brace-style': 'off',
         curly: 'error',
         eqeqeq: ['error', 'always'],

src/atlclients/responseHandlers/BitbucketResponseHandler.ts

@@ -64,7 +64,7 @@ export class BitbucketResponseHandler extends ResponseHandler {
                         email = primary[0].email;
                     }
                 }
-            } catch (e) {
+            } catch {
                 //ignore
             }
 

src/bitbucket/bitbucket-cloud/pullRequests.ts

@@ -353,7 +353,7 @@ export class CloudPullRequestApi implements PullRequestApi {
             }
 
             return accumulatedTasks.map((task: any) => this.convertDataToTask(task, pr.site));
-        } catch (e) {
+        } catch {
             return [];
         }
     }
@@ -624,7 +624,7 @@ export class CloudPullRequestApi implements PullRequestApi {
                 });
 
                 return (data.values || []).map((reviewer: any) => CloudPullRequestApi.toUserModel(reviewer.user));
-            } catch (e) {
+            } catch {
                 return [];
             }
         }
@@ -648,7 +648,7 @@ export class CloudPullRequestApi implements PullRequestApi {
             }
 
             return teamMembers.map((m: any) => CloudPullRequestApi.toUserModel(m.user));
-        } catch (e) {
+        } catch {
             return [];
         }
     }

src/bitbucket/bitbucket-server/pullRequests.ts

@@ -639,7 +639,7 @@ export class ServerPullRequestApi implements PullRequestApi {
                         } else {
                             return 1;
                         }
-                    } catch (e) {
+                    } catch {
                         return a.ts!! ? 1 : -1;
                     }
                 }),

src/bitbucket/bitbucket-server/repositories.ts

@@ -14,7 +14,7 @@ export class ServerRepositoriesApi implements RepositoriesApi {
             const { data } = await this.client.get(`/rest/mirroring/1.0/mirrorServers?limit=100`);
 
             return data.values.map((val: any) => new URL(val.baseUrl).hostname);
-        } catch (e) {
+        } catch {
             // ignore
         }
         return [];

src/commands/jira/showIssue.ts

@@ -70,7 +70,7 @@ export async function showIssueForKey(issueKey?: string) {
     if (issueKey) {
         try {
             issue = await issueForKey(issueKey);
-        } catch (e) {
+        } catch {
             //not found
         }
     }

src/jira/projectManager.ts

@@ -32,7 +32,7 @@ export class JiraProjectManager extends Disposable {
         try {
             const client = await Container.clientManager.jiraClient(site);
             return await client.getProject(projectKey);
-        } catch (e) {
+        } catch {
             //continue
         }
 
@@ -45,7 +45,7 @@ export class JiraProjectManager extends Disposable {
             if (projects.length > 0) {
                 return projects[0];
             }
-        } catch (e) {
+        } catch {
             //continue
         }
 

src/lib/webview/controller/startwork/startWorkWebviewController.ts

@@ -193,7 +193,7 @@ export class StartWorkWebviewController implements WebviewController<StartWorkIs
                         imgData: imgData,
                         nonce: msg.nonce,
                     } as any);
-                } catch (e) {
+                } catch {
                     this.logger.error(new Error(`error fetching image: ${msg.url}`));
                     this.postMessage({
                         type: 'getImageDone',

src/react/atlascode/common/form/useFormValidation.tsx

@@ -86,7 +86,7 @@ export function useFormValidation<FieldTypes>(watch?: Partial<FieldTypes>): Form
     const watchDefaults = useRef<Partial<FieldTypes>>(watch ? watch : {});
     const watches = useRef<Partial<FieldTypes>>(watch ? watch : {});
     const errors = useRef<Partial<Errors<FieldTypes>>>({});
-    const [_toggle, reRender] = useState(false);
+    const [, reRender] = useState(false);
 
     const handleChange = useConstant(() => async (e: Event) => {
         const field = fields[(e.target as InputElement).name];

src/react/atlascode/config/auth/dialog/AuthDialog.tsx

@@ -237,7 +237,7 @@ function isCustomUrl(url: string): boolean {
     try {
         const urlObj = new URL(url);
         return cloudHostnames.every((host) => !urlObj.hostname.endsWith(host));
-    } catch (e) {
+    } catch {
         return false;
     }
 }