Add eslint rule: Disallow unused variables (#118)

.eslintrc.js

@@ -53,6 +53,12 @@ module.exports = {
                 ],
             },
         ],
+        "no-unused-vars": ["error", {
+            "vars": "all",
+            "args": "none",
+            "caughtErrors": "all",
+            "ignoreRestSiblings": false,
+        }],        
         'brace-style': 'off',
         curly: 'error',
         eqeqeq: ['error', 'always'],

src/atlclients/responseHandlers/BitbucketResponseHandler.ts

@@ -64,7 +64,7 @@ export class BitbucketResponseHandler extends ResponseHandler {
                         email = primary[0].email;
                     }
                 }
-            } catch (e) {
+            } catch {
                 //ignore
             }
 

src/bitbucket/bitbucket-cloud/pullRequests.ts

@@ -353,7 +353,7 @@ export class CloudPullRequestApi implements PullRequestApi {
             }
 
             return accumulatedTasks.map((task: any) => this.convertDataToTask(task, pr.site));
-        } catch (e) {
+        } catch {
             return [];
         }
     }
@@ -624,7 +624,7 @@ export class CloudPullRequestApi implements PullRequestApi {
                 });
 
                 return (data.values || []).map((reviewer: any) => CloudPullRequestApi.toUserModel(reviewer.user));
-            } catch (e) {
+            } catch {
                 return [];
             }
         }
@@ -648,7 +648,7 @@ export class CloudPullRequestApi implements PullRequestApi {
             }
 
             return teamMembers.map((m: any) => CloudPullRequestApi.toUserModel(m.user));
-        } catch (e) {
+        } catch {
             return [];
         }
     }

src/bitbucket/bitbucket-server/pullRequests.ts

@@ -639,7 +639,7 @@ export class ServerPullRequestApi implements PullRequestApi {
                         } else {
                             return 1;
                         }
-                    } catch (e) {
+                    } catch {
                         return a.ts!! ? 1 : -1;
                     }
                 }),

src/bitbucket/bitbucket-server/repositories.ts

@@ -14,7 +14,7 @@ export class ServerRepositoriesApi implements RepositoriesApi {
             const { data } = await this.client.get(`/rest/mirroring/1.0/mirrorServers?limit=100`);
 
             return data.values.map((val: any) => new URL(val.baseUrl).hostname);
-        } catch (e) {
+        } catch {
             // ignore
         }
         return [];

src/commands/jira/showIssue.ts

@@ -70,7 +70,7 @@ export async function showIssueForKey(issueKey?: string) {
     if (issueKey) {
         try {
             issue = await issueForKey(issueKey);
-        } catch (e) {
+        } catch {
             //not found
         }
     }

src/jira/projectManager.ts

@@ -32,7 +32,7 @@ export class JiraProjectManager extends Disposable {
         try {
             const client = await Container.clientManager.jiraClient(site);
             return await client.getProject(projectKey);
-        } catch (e) {
+        } catch {
             //continue
         }
 
@@ -45,7 +45,7 @@ export class JiraProjectManager extends Disposable {
             if (projects.length > 0) {
                 return projects[0];
             }
-        } catch (e) {
+        } catch {
             //continue
         }
 

src/lib/webview/controller/startwork/startWorkWebviewController.ts

@@ -193,7 +193,7 @@ export class StartWorkWebviewController implements WebviewController<StartWorkIs
                         imgData: imgData,
                         nonce: msg.nonce,
                     } as any);
-                } catch (e) {
+                } catch {
                     this.logger.error(new Error(`error fetching image: ${msg.url}`));
                     this.postMessage({
                         type: 'getImageDone',

src/react/atlascode/common/form/useFormValidation.tsx

@@ -86,7 +86,7 @@ export function useFormValidation<FieldTypes>(watch?: Partial<FieldTypes>): Form
     const watchDefaults = useRef<Partial<FieldTypes>>(watch ? watch : {});
     const watches = useRef<Partial<FieldTypes>>(watch ? watch : {});
     const errors = useRef<Partial<Errors<FieldTypes>>>({});
-    const [_toggle, reRender] = useState(false);
+    const [, reRender] = useState(false);
 
     const handleChange = useConstant(() => async (e: Event) => {
         const field = fields[(e.target as InputElement).name];

src/react/atlascode/config/auth/dialog/AuthDialog.tsx

@@ -237,7 +237,7 @@ function isCustomUrl(url: string): boolean {
     try {
         const urlObj = new URL(url);
         return cloudHostnames.every((host) => !urlObj.hostname.endsWith(host));
-    } catch (e) {
+    } catch {
         return false;
     }
 }

src/react/atlascode/startwork/StartWorkPage.tsx

@@ -250,7 +250,7 @@ const StartWorkPage: React.FunctionComponent = () => {
             setSubmitState('submit-success');
             setSubmitResponse(response);
             setSuccessSnackbarOpen(true);
-        } catch (e) {
+        } catch {
             setSubmitState('initial');
         }
     }, [

src/react/index-dev.tsx

@@ -13,6 +13,7 @@ import { createVSCodeTheme } from './vscode/theme/vscodeTheme';
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
 declare var __webpack_public_path__: string;
+// eslint-disable-next-line no-unused-vars
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {
@@ -73,7 +74,7 @@ class VsCodeApi {
             try {
                 var json = JSON.parse(message.data);
                 window.postMessage(json.data, '*');
-            } catch (e) {
+            } catch {
                 console.error('Invalid JSON: ', message.data);
                 return;
             }

src/react/index.tsx

@@ -14,6 +14,7 @@ import { createVSCodeTheme } from './vscode/theme/vscodeTheme';
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
 declare var __webpack_public_path__: string;
+// eslint-disable-next-line no-unused-vars
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {

src/util/keychain.ts

@@ -8,12 +8,12 @@ function getNodeModule<T>(moduleName: string): T | undefined {
     const vscodeRequire = eval('require');
     try {
         return vscodeRequire(`${vscode.env.appRoot}/node_modules.asar/${moduleName}`);
-    } catch (err) {
+    } catch {
         // Not in ASAR.
     }
     try {
         return vscodeRequire(`${vscode.env.appRoot}/node_modules/${moduleName}`);
-    } catch (err) {
+    } catch {
         // Not available.
     }
     return undefined;

src/views/BitbucketActivityMonitor.ts

@@ -1,3 +1,3 @@
-interface BitbucketActivityMonitor {
+export interface BitbucketActivityMonitor {
     checkForNewActivity(): void;
 }

src/views/BitbucketExplorer.ts

@@ -11,6 +11,7 @@ import { CreatePullRequestNode } from './pullrequest/headerNode';
 import { DescriptionNode, PullRequestTitlesNode } from './pullrequest/pullRequestNode';
 import { PullRequestNodeDataProvider } from './pullRequestNodeDataProvider';
 import { RefreshTimer } from './RefreshTimer';
+import { BitbucketActivityMonitor } from './BitbucketActivityMonitor';
 
 export abstract class BitbucketExplorer extends Explorer implements Disposable {
     private _disposable: Disposable;

src/views/bbissues/bbIssuesExplorer.ts

@@ -13,6 +13,7 @@ import { BitbucketIssuesDataProvider } from '../bitbucketIssuesDataProvider';
 import { BaseTreeDataProvider } from '../Explorer';
 import { BitbucketIssuesMonitor } from './bbIssuesMonitor';
 import { BitbucketSite } from '../../bitbucket/model';
+import { BitbucketActivityMonitor } from '../BitbucketActivityMonitor';
 
 export class BitbucketIssuesExplorer extends BitbucketExplorer {
     constructor(ctx: BitbucketContext) {

src/views/bbissues/bbIssuesMonitor.ts

@@ -3,6 +3,7 @@ import * as vscode from 'vscode';
 import { clientForSite } from '../../bitbucket/bbUtils';
 import { BitbucketIssue, WorkspaceRepo } from '../../bitbucket/model';
 import { Commands } from '../../commands';
+import { BitbucketActivityMonitor } from '../BitbucketActivityMonitor';
 
 export class BitbucketIssuesMonitor implements BitbucketActivityMonitor {
     private _lastCheckedTime = new Map<String, Date>();

src/views/gitContentProvider.ts

@@ -41,7 +41,7 @@ export class GitContentProvider implements vscode.TextDocumentContentProvider {
                     const absolutePath = pathlib.join(scm.rootUri.fsPath, path);
                     try {
                         return await scm.show(commitHash, absolutePath);
-                    } catch (err) {
+                    } catch {
                         await scm.fetch(wsRepo!.mainSiteRemote.remote.name, branchName);
                         return await scm.show(commitHash, absolutePath);
                     }
@@ -52,7 +52,7 @@ export class GitContentProvider implements vscode.TextDocumentContentProvider {
                     return fileContent;
                 })(),
             ]);
-        } catch (err) {
+        } catch {
             vscode.window.showErrorMessage(
                 `We couldn't find ${path} at commit ${commitHash}. You may want to sync the branch with remote. Sometimes commits can disappear after a force-push.`,
             );

src/views/jira/activeIssueStatusBar.ts

@@ -102,7 +102,7 @@ export class JiraActiveIssueStatusBar implements Disposable {
             try {
                 const issue = (await getCachedIssue(parsedIssueKeys[0])) || (await issueForKey(parsedIssueKeys[0]));
                 this.updateStatusBarItem(issue);
-            } catch (e) {
+            } catch {
                 // do nothing
             }
         }
@@ -122,7 +122,7 @@ export class JiraActiveIssueStatusBar implements Disposable {
             try {
                 const uriPath = fs.realpathSync(editor.document.uri.fsPath);
                 return uriPath.startsWith(repo.rootUri.fsPath);
-            } catch (e) {
+            } catch {
                 return false;
             }
         });

src/views/jira/issueHoverProvider.ts

@@ -21,7 +21,7 @@ export class IssueHoverProvider implements HoverProvider {
         let issue = undefined;
         try {
             issue = await issueForKey(key);
-        } catch (e) {
+        } catch {
             return Promise.reject(`issue not found ${key}`);
         }
 

src/views/pipelines/PipelinesExplorer.ts

@@ -9,6 +9,7 @@ import { PipelinesMonitor } from './PipelinesMonitor';
 import { Commands } from '../../commands';
 import { BitbucketExplorer } from '../BitbucketExplorer';
 import { BaseTreeDataProvider } from '../Explorer';
+import { BitbucketActivityMonitor } from '../BitbucketActivityMonitor';
 
 export class PipelinesExplorer extends BitbucketExplorer {
     constructor(ctx: BitbucketContext) {

src/views/pipelines/PipelinesMonitor.ts

@@ -5,6 +5,7 @@ import { Commands } from '../../commands';
 import { Container } from '../../container';
 import { Pipeline, PipelineTarget } from '../../pipelines/model';
 import { descriptionForState, generatePipelineTitle, shouldDisplay } from './Helpers';
+import { BitbucketActivityMonitor } from '../BitbucketActivityMonitor';
 
 export class PipelinesMonitor implements BitbucketActivityMonitor {
     private _previousResults: Map<string, Pipeline[]> = new Map();

src/views/pullrequest/pullRequestCreatedMonitor.ts

@@ -4,6 +4,7 @@ import { BitbucketContext } from '../../bitbucket/bbContext';
 import { clientForSite } from '../../bitbucket/bbUtils';
 import { Commands } from '../../commands';
 import { Logger } from '../../logger';
+import { BitbucketActivityMonitor } from '../BitbucketActivityMonitor';
 
 export class PullRequestCreatedMonitor implements BitbucketActivityMonitor {
     private _lastCheckedTime = new Map<String, Date>();

src/views/pullrequest/pullRequestsExplorer.ts

@@ -11,6 +11,7 @@ import { BitbucketExplorer } from '../BitbucketExplorer';
 import { BaseTreeDataProvider } from '../Explorer';
 import { PullRequestNodeDataProvider } from '../pullRequestNodeDataProvider';
 import { PullRequestCreatedMonitor } from './pullRequestCreatedMonitor';
+import { BitbucketActivityMonitor } from '../BitbucketActivityMonitor';
 
 export class PullRequestsExplorer extends BitbucketExplorer {
     constructor(ctx: BitbucketContext) {

src/webview/pullrequest/vscCreatePullRequestActionImpl.ts

@@ -103,7 +103,7 @@ export class VSCCreatePullRequestActionApi implements CreatePullRequestActionApi
             if (jiraIssueKeys.length > 0) {
                 try {
                     return await issueForKey(jiraIssueKeys[0]);
-                } catch (e) {
+                } catch {
                     //not found
                 }
             }
@@ -125,7 +125,7 @@ export class VSCCreatePullRequestActionApi implements CreatePullRequestActionApi
         try {
             const bbApi = await clientForSite(site);
             commits = await bbApi.repositories.getCommitsForRefs(site, sourceBranchName, destinationBranchName);
-        } catch (e) {}
+        } catch {}
 
         const shell = new Shell(Uri.parse(wsRepo.rootUri).fsPath);
         const diff = await shell.output(

src/webview/startwork/vscStartWorkActionApi.ts

@@ -59,14 +59,14 @@ export class VSCStartWorkActionApi implements StartWorkActionApi {
             await scm.getBranch(destinationBranch);
             await scm.checkout(destinationBranch);
             return;
-        } catch (_) {}
+        } catch {}
 
         // checkout if there's a matching remote branch (checkout will track remote branch automatically)
         try {
             await scm.getBranch(`remotes/${remote}/${destinationBranch}`);
             await scm.checkout(destinationBranch);
             return;
-        } catch (_) {}
+        } catch {}
 
         // no existing branches, create a new one
         await scm.createBranch(

src/webviews/components/WebviewComponent.tsx

@@ -13,7 +13,6 @@ interface VsCodeApi {
 
 declare function acquireVsCodeApi(): VsCodeApi;
 
-export interface WebviewComponent<A extends Action, R, P = {}, S = {}> extends React.Component<P, S> {}
 // WebviewComponent is the base React component for creating a webview in vscode.
 // This handles comms between vscode and react.
 // Generic Types:

src/webviews/components/fieldValidators.ts

@@ -55,7 +55,7 @@ export function validateUrl(value: string, state?: any): string | undefined {
         if (url.hostname === '') {
             err = 'NOT_URL';
         }
-    } catch (e) {
+    } catch {
         err = 'NOT_URL';
     }
 

src/webviews/components/index-dev.tsx

@@ -7,6 +7,7 @@ import './App.css';
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
 declare var __webpack_public_path__: string;
+// eslint-disable-next-line no-unused-vars
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {
@@ -35,7 +36,7 @@ class VsCodeApi {
             try {
                 var json = JSON.parse(message.data);
                 window.postMessage(json.data, '*');
-            } catch (e) {
+            } catch {
                 return;
             }
         };

src/webviews/components/index.tsx

@@ -5,6 +5,7 @@ import './App.css';
 // @ts-ignore
 // __webpack_public_path__ is used to set the public path for the js files - https://webpack.js.org/guides/public-path/
 declare var __webpack_public_path__: string;
+// eslint-disable-next-line no-unused-vars
 __webpack_public_path__ = `${document.baseURI!}build/`;
 
 const routes = {

src/webviews/components/issue/AbstractIssueEditorPage.tsx

@@ -277,7 +277,7 @@ export abstract class AbstractIssueEditorPage<
                         nonce,
                     );
                     resolve((listEvent as IssueSuggestionsList).issues);
-                } catch (e) {
+                } catch {
                     resolve([]);
                 }
             })();
@@ -322,7 +322,7 @@ export abstract class AbstractIssueEditorPage<
 
                     this.setState({ isSomethingLoading: false });
                     resolve(listEvent.options);
-                } catch (e) {
+                } catch {
                     this.setState({ isSomethingLoading: false });
                     resolve([]);
                 }
@@ -364,7 +364,7 @@ export abstract class AbstractIssueEditorPage<
                             ...createEvent.selectFieldOptions,
                         },
                     });
-                } catch (e) {
+                } catch {
                     this.setState({ isSomethingLoading: false });
                 }
             })();

src/webviews/components/issue/JiraIssuePage.tsx

@@ -859,7 +859,7 @@ export default class JiraIssuePage extends AbstractIssueEditorPage<Emit, Accept,
         try {
             created = `Created ${formatDistanceToNow(parseISO(this.state.fieldValues['created']))} ago`;
             updated = `Updated ${formatDistanceToNow(parseISO(this.state.fieldValues['updated']))} ago`;
-        } catch (e) {
+        } catch {
             created = this.state.fieldValues['created.rendered'] || this.state.fieldValues['created'];
             updated = this.state.fieldValues['updated.rendered'] || this.state.fieldValues['updated'];
         }

src/webviews/jiraIssueWebview.ts

@@ -946,7 +946,7 @@ export class JiraIssueWebview
                                 imgData: imgData,
                                 nonce: msg.nonce,
                             });
-                        } catch (e) {
+                        } catch {
                             Logger.error(new Error(`error fetching image: ${msg.url}`));
                             this.postMessage({
                                 type: 'getImageDone',