Fix container deleting global stores (#106)

Author: albertogasparin

src/components/__tests__/container.test.js

@@ -173,13 +173,14 @@ describe('Container', () => {
       expect(mockOnContainerCleanupInner).toHaveBeenCalledTimes(1);
     });
 
-    it('should not cleanup from global on unmount if still listeners', () => {
+    it('should not cleanup from global on unmount if still listeners', async () => {
       storeStateMock.subscribe.mockReturnValue(jest.fn());
       storeStateMock.listeners.mockReturnValue([jest.fn()]);
       const Subscriber = createSubscriber(Store);
       const children = <Subscriber>{() => null}</Subscriber>;
       const wrapper = mount(<Container scope="s1">{children}</Container>);
       wrapper.unmount();
+      await Promise.resolve();
       expect(defaultRegistry.deleteStore).not.toHaveBeenCalled();
     });
 
@@ -193,6 +194,14 @@ describe('Container', () => {
       expect(defaultRegistry.deleteStore).toHaveBeenCalledWith(Store, 's1');
     });
 
+    it('should not cleanup from global on unmount if not scoped', async () => {
+      storeStateMock.listeners.mockReturnValue([]);
+      const wrapper = mount(<Container isGlobal>Content</Container>);
+      wrapper.unmount();
+      await Promise.resolve();
+      expect(defaultRegistry.deleteStore).not.toHaveBeenCalled();
+    });
+
     it('should call Container onInit on first render', () => {
       const Subscriber = createSubscriber(Store);
       const renderPropChildren = jest.fn().mockReturnValue(null);

src/components/container.js

@@ -161,7 +161,7 @@ export default class Container extends Component {
   deleteScopedStore(scopeId = this.props.scope) {
     const { storeType } = this.constructor;
     const { storeState } = this.getScopedStore(storeType, scopeId);
-    if (!storeState.listeners().length) {
+    if (scopeId != null && !storeState.listeners().length) {
       this.getRegistry().deleteStore(storeType, scopeId);
     }
   }