Fix/missing secret env (#402)

* Added missing secret in env

* test: deployment

* feat: run the action on push

---------

Co-authored-by: ceelogre <[email protected]>

Author: MugemaneBertin2001

.github/workflows/deployments.yml

@@ -3,6 +3,7 @@ on:
   push:
     branches:
       - develop
+  
   workflow_dispatch:
 
 jobs:

src/context.ts

@@ -4,7 +4,7 @@ import { Request } from 'express'
 import * as jwt from 'jsonwebtoken'
 import requestIp from 'request-ip'
 
-const SECRET = process.env.SECRET
+const SECRET = (process.env.SECRET as string) || 'mysq_unique_secret'
 
 export interface AuthTokenPayload {
   userId: string

src/helpers/generateInvitationToken.helper.ts

@@ -1,5 +1,5 @@
 import jwt from 'jsonwebtoken'
-const SECRET: string = process.env.SECRET as string
+const SECRET = (process.env.SECRET as string) || 'mysq_unique_secret'
 
 export default async function generateInvitationTokenAndLink(
   email: string,

src/helpers/organization.helper.ts

@@ -4,7 +4,7 @@ import { JwtPayload, verify } from 'jsonwebtoken'
 import { Organization } from '../models/organization.model'
 
 export async function checkLoggedInOrganization(token?: string) {
-  const SECRET = process.env.SECRET as string
+  const SECRET = (process.env.SECRET as string) || 'mysq_unique_secret'
 
   if (!token) {
     throw new GraphQLError('Not logged in an organization', {

src/helpers/sendEventEmails.ts

@@ -18,7 +18,7 @@ export async function sendEventInvitations(
   eventTimeToEnd: string
 ) {
   try {
-    const secret = process.env.SECRET!
+    const secret = (process.env.SECRET as string) || 'mysq_unique_secret'
     const acceptedEventToken = jwt.sign(
       {
         email,

src/helpers/sendInvitaitonEmail.ts

@@ -11,7 +11,7 @@ interface Payload {
   orgToken: string
 }
 
-const SECRET: string = process.env.SECRET as string
+const SECRET = (process.env.SECRET as string) || 'mysq_unique_secret'
 export default async function sendInvitationEmail(
   email: string,
   orgName: string,

src/helpers/user.helpers.ts

@@ -3,7 +3,7 @@ import { RoleOfUser, User } from '../models/user'
 import { Context } from './../context'
 import * as jwt from 'jsonwebtoken'
 
-const SECRET: string = process.env.SECRET as string
+const SECRET = (process.env.SECRET as string) || 'mysq_unique_secret'
 
 export const generateToken = (userId: string, role: string) => {
   return jwt.sign({ userId, role }, SECRET, { expiresIn: '2h' })

src/resolvers/cohort.resolvers.ts

@@ -318,12 +318,16 @@ const resolvers = {
 
       if (
         endDate &&
-        (isAfter(new Date(startDate.toString()),
-          new Date(endDate.toString())) ||
-        isAfter(new Date(cohort?.startDate?.toString() || ''),
-          new Date(endDate)))
+        (isAfter(
+          new Date(startDate.toString()),
+          new Date(endDate.toString())
+        ) ||
+          isAfter(
+            new Date(cohort?.startDate?.toString() || ''),
+            new Date(endDate)
+          ))
       ) {
-        throw new GraphQLError('End Date can\'t be before Start Date', {
+        throw new GraphQLError("End Date can't be before Start Date", {
           extensions: {
             code: 'VALIDATION_ERROR',
           },
@@ -402,9 +406,8 @@ const resolvers = {
         cohort.name = name
         notificationChanges.push('Name')
       }
-      if (phaseName && cohort.phase.toString() !== phase.id.toString()) {
-        cohort.phase = phase.id;
-        addNewAttendanceWeek();
+      if (phaseName && cohort?.phase?.toString() !== phase?.id?.toString()) {
+        cohort.phase = phase.id
         notificationChanges.push('Phase')
       }
 

src/resolvers/coordinatorResolvers.ts

@@ -19,7 +19,7 @@ import RemoveTraineeTemplate from '../utils/templates/removeTraineeTamplete'
 import { Context } from './../context'
 import { Document, ObjectId } from 'mongoose'
 
-const SECRET: string = process.env.SECRET as string
+const SECRET = (process.env.SECRET as string) || 'mysq_unique_secret'
 
 interface TraineeStatus {
   days: string

src/resolvers/eventResolver.ts

@@ -61,7 +61,10 @@ const validateTime = (
 
 const decodeEventResponseToken = (token: string) => {
   try {
-    return jwt.verify(token, process.env.SECRET!) as EventResponse
+    return jwt.verify(
+      token,
+      (process.env.SECRET as string) || 'mysq_unique_secret'
+    ) as EventResponse
   } catch (err: any) {
     throw new GraphQLError('Invalid Token', {
       extensions: {