Skip to content

Commit 4e16378

Browse files
UziTechaminya
andauthored
fix: update deps (#149)
Co-authored-by: Amin Yahyaabadi <[email protected]>
1 parent dbbd71c commit 4e16378

File tree

4 files changed

+208
-151
lines changed

4 files changed

+208
-151
lines changed

lib/adapters/autocomplete-adapter.ts

+12-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Convert from "../convert"
22
import * as Utils from "../utils"
33
import { CancellationTokenSource } from "vscode-jsonrpc"
44
import { ActiveServer } from "../server-manager"
5-
import { filter } from "zadeh"
5+
import { ObjectArrayFilterer } from "zadeh"
66
import {
77
CompletionContext,
88
CompletionItem,
@@ -133,7 +133,17 @@ export default class AutocompleteAdapter {
133133
}
134134

135135
const filtered = !(request.prefix === "" || (triggerChar !== "" && triggerOnly))
136-
return filtered ? filter(suggestions, request.prefix, { key: "filterText" }) : suggestions
136+
if (filtered) {
137+
// filter the suggestions who have `filterText` property
138+
const validSuggestions = suggestions.filter((sgs) => typeof sgs.filterText === "string") as Suggestion[] &
139+
{ filterText: string }[]
140+
// TODO use `ObjectArrayFilterer.setCandidate` in `_suggestionCache` to avoid creating `ObjectArrayFilterer` every time from scratch
141+
const objFilterer = new ObjectArrayFilterer(validSuggestions, "filterText")
142+
// zadeh returns an array of the selected `Suggestions`
143+
return (objFilterer.filter(request.prefix) as any) as Suggestion[]
144+
} else {
145+
return suggestions
146+
}
137147
}
138148

139149
private shouldTrigger(request: ac.SuggestionsRequestedEvent, triggerChar: string, minWordLength: number): boolean {

lib/download-file.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ export default (async function downloadFile(
5151
*/
5252
async function streamWithProgress(
5353
length: number,
54-
reader: ReadableStreamReader,
54+
reader: ReadableStreamReader<Uint8Array>,
5555
writer: fs.WriteStream,
5656
progressCallback?: ByteProgressCallback
5757
): Promise<void> {

package.json

+12-12
Original file line numberDiff line numberDiff line change
@@ -27,28 +27,28 @@
2727
"atomTestRunner": "./test/runner",
2828
"dependencies": {
2929
"@types/rimraf": "^3.0.0",
30-
"atom-ide-base": "^2.4.0",
30+
"atom-ide-base": "^2.6.0",
3131
"rimraf": "^3.0.2",
3232
"vscode-jsonrpc": "6.0.0",
3333
"vscode-languageserver-protocol": "3.16.0",
3434
"vscode-languageserver-types": "3.16.0",
35-
"zadeh": "2.0.2"
35+
"zadeh": "3.0.0-beta.2"
3636
},
3737
"devDependencies": {
3838
"@atom/mocha-test-runner": "^1.6.1",
3939
"@types/atom": "^1.40.10",
40-
"@types/chai": "^4.2.14",
41-
"@types/mocha": "^8.2.0",
42-
"@types/node": "14.14.22",
43-
"@types/sinon": "^9.0.10",
44-
"chai": "^4.2.0",
45-
"eslint-config-atomic": "^1.14.0",
40+
"@types/chai": "^4.2.16",
41+
"@types/mocha": "^8.2.2",
42+
"@types/node": "14.14.41",
43+
"@types/sinon": "^10.0.0",
44+
"chai": "^4.3.4",
45+
"eslint-config-atomic": "^1.14.1",
4646
"eslint-plugin-chai-friendly": "^0.6.0",
47-
"mocha": "^8.2.1",
47+
"mocha": "^8.3.2",
4848
"mocha-appveyor-reporter": "^0.4.2",
49-
"prettier-config-atomic": "^2.0.1",
49+
"prettier-config-atomic": "^2.0.2",
5050
"shx": "^0.3.3",
51-
"sinon": "^9.2.4",
52-
"typescript": "~4.1.3"
51+
"sinon": "^10.0.0",
52+
"typescript": "~4.2.4"
5353
}
5454
}

0 commit comments

Comments
 (0)