Skip to content

Commit 22dd0d8

Browse files
committed
fix: fix faulty keep modules
1 parent f4c75ff commit 22dd0d8

File tree

1 file changed

+22
-13
lines changed

1 file changed

+22
-13
lines changed

index.js

+22-13
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,28 @@
22
// replacing `"(@babel.*)",` with `require("$1"),`
33
// replacing `module.exports = {(\s\S*)}` with `module.exports = () => {return $1}`
44

5+
let keepModules = false // false by default
6+
7+
if (process.env.BABEL_ENV === "production") {
8+
keepModules = true
9+
console.warn("setting `BABEL_ENV` to `production` for bypassing ES6 module transformming is deprecated. Use BABEL_KEEP_MODULES=\"true\" instead.")
10+
}
11+
12+
if (process.env.BABEL_ENV === "development") {
13+
console.warn("setting `BABEL_ENV` to `development` for transforming ES6 modules is deprecated. Use BABEL_KEEP_MODULES=\"false\" instead.")
14+
}
15+
16+
if (process.env.BABEL_KEEP_MODULES === "true") {
17+
keepModules = true
18+
}
19+
520
let presets = [
621
[
722
require("@babel/preset-env"),
823
{
924
targets: {
1025
electron: 5,
26+
modules: keepModules
1127
},
1228
},
1329
],
@@ -36,24 +52,17 @@ let plugins = [
3652
require("@babel/plugin-proposal-json-strings"),
3753
];
3854

39-
if (process.env.BABEL_ENV === "production") {
40-
console.warn("setting `BABEL_ENV` to `production` for bypassing ES6 module transformming is deprecated. Use BABEL_KEEP_MODULES=\"true\" instead.")
41-
}
42-
43-
if (process.env.BABEL_ENV === "development") {
44-
console.warn("setting `BABEL_ENV` to `development` for transform ES6 modules is deprecated. Use BABEL_KEEP_MODULES=\"false\" instead.")
45-
}
4655

47-
// tranform modules
48-
if (process.env.BABEL_KEEP_MODULES === "false" || !(process.env.BABEL_KEEP_MODULES) || process.env.BABEL_ENV === "development" || !(process.env.BABEL_ENV)) {
49-
// When without Rollup
56+
// transform modules (e.g when without Rollup)
57+
if (!keepModules) {
5058
plugins.push(...[
51-
require("@babel/plugin-transform-modules-commonjs"),
52-
require("@babel/plugin-syntax-dynamic-import"),
53-
require("babel-plugin-add-module-exports",{"addDefaultProperty": true}) // atom needs this
59+
require("@babel/plugin-transform-modules-commonjs"),
60+
require("@babel/plugin-syntax-dynamic-import"),
61+
require("babel-plugin-add-module-exports",{"addDefaultProperty": true}) // atom needs this
5462
]);
5563
}
5664

65+
5766
module.exports = () => {return {
5867
presets: presets,
5968
plugins: plugins,

0 commit comments

Comments
 (0)