Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

project root != language server root #233

Open
@lloiser

Description

@lloiser

Let's imagine several projects combined in one large git repository. Each of these projects has their own root folder in this repo. They are all related to each other so it makes sense to open them in 1 atom instance instead of opening several atom instances and switching between them.

AFAIK this is currently not supported by the AutoLanguageClient because the server always takes the atom root folder as projectPath that is then passed to the startServerProcess function.

There is already the determineProjectPath function on the ServerManager:

public determineProjectPath(textEditor: TextEditor): string | null {
const filePath = textEditor.getPath();
if (filePath == null) {
return null;
}
return this._normalizedProjectPaths.find((d) => filePath.startsWith(d)) || null;
}

If this can be overwritten by the AutoLanguageClient in some way then I think the above mentioned problem is fixed.

What do you think? I think I can prepare a PR for this.

/cc @damieng

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions