Bug when password refused

[VB-is-Terrible]

Description

The git module hangs when a password is requested, but not given

Steps to Reproduce

edit from @rsese: make sure credential caching is disabled if necessary so you're prompted for username/password

1. (Pre) Have a atom open in git repo, with commits to push
2. Push
3. When atom requests a password, either press escape or click the cancel button (appears twice for me)

Expected behavior:

The git module continues working

Actual behavior:

The git module hangs. No git diffs are generated, changes cannot be added to the staged commit, no changes are detected in the git panel.

Reproduces how often:

100%

Versions

Atom : 1.21.0
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0

And the beta:
Atom : 1.22.0-beta0
Electron: 1.6.9
Chrome : 56.0.2924.87
Node : 7.4.0

OS: Ubuntu 17.04 (linux)

Additional Information

Relevant parts of my .gitconfig:
[credential]
helper = cache
help = cache --timeout=3600
[url "https://VB-is-Terrible@github.com"]
insteadOf = https://github.com

Before steps:

Password box:

After:

The spinner spins for a while, then stops spinning, but keeps the cycle icon

[rsese]

Thanks for the report - I can reproduce on macOS 10.12.6 with Atom 1.23.0-dev-bdfa61e84 after disabling credential caching in my .gitconfig and then following your step to reproduce.

I also have Git Diagnostics enabled but after canceling twice, there's no output in console after trying to stage another unstaged change, modifying a file and expecting it to show up as an unstaged change, etc.

/cc @kuychaco @BinaryMuse ✌️

[xenithorb]

I still think this is an issue today with 0.14.5

What happens is my SSH-agent locks itself after a few hours, and then I go to push something and the password box pops up asking me for a password to the git@server account.

I cancel this because I know what I really need to do is up my ssh-agent again properly.

After doing so, and escaping from the password prompt it's stuck in "Pushing " mode until I restart atom. I keep running into this for obvious reasons