Editor keyboard focus is lost when hotkey switching from "Unstaged Changes" tab

@yarozar commented on Aug 27, 2018, 1:15 PM UTC:

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

When switching from tab "Unstaged Changes: ..." using hotkey like Alt+Cmd+[ you loose keyboard focus from your editor window.

Steps to Reproduce

1. Have in one tab simple file.
2. Open another tab with simple text file.
3. Have "Unstaged Changes: ..." tab opened using Git Tab and highlighting changed file.
4. Switch back to file tab using Alt+Cmd+[, observe keyboard focus lost.

Expected behavior: Keyboard focus should not be lost when switching from "Unstaged Changes:..." tab.

Actual behavior: Keyboard focus is lost.

Reproduces how often: 100%

Versions

$ atom --version
Atom : 1.29.0
Electron: 2.0.5
Chrome : 61.0.3163.100
Node : 8.9.3

$ apm --version
apm 1.19.0
npm 3.10.10
node 6.9.5 x64
atom 1.29.0
python 2.7.10
git 2.15.2

$ sw_vers
ProductName: Mac OS X
ProductVersion: 10.13.6
BuildVersion: 17G65

This issue was moved by rsese from atom/atom#17932.

[rsese]

Thanks for the report @yarozar - just to clarify, in your step 3:

3. Have "Unstaged Changes: ..." tab opened using Git Tab and highlighting changed file.

When you say "and highlighting changed file", do you mean that after clicking on an item in the Unstaged Changes section, you click on the diff view tab itself?

[yarozar]

1. Have tab with text file opened.
2. Open Git tab pane with some unstaged changes file.
3. Click on that unstaged file in Git tab, have new tab open named “Unstaged Changes....”.

Now we have two tabs - one with tex file and another “Unstaged changes”.

When switching between tabs using keyboard hotkey Alt+Cmd+[ then the tab with simple text file looses keyboard cursor focus... By the way when you switch tabs using mouse click on tab names - this does not happen and everything works properly.

[wadethestealth]

@yarozar what command is the hotkey alt+cmd+[ bound to? window:focus-next-pane?

[yarozar]

@wadethestealth, there was mistake with hotkey command - should have been "Shift + Cmd + [" (standard editor switching tabs hotkey).

But I can not reproduce that issue at the moment - the problem was that when you were switching between "Unstaged Changes: ..." editor tab and regular editor tab using keyboard shorcut you was unable to start editing file - it was like in some "read-only" mode.

I have filed that issue quite some time ago, guess it was fixed in one the versions afterwards.