Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

login is shown on GitHub tab when internet is disabled. #1732

Open
@annthurium

Description

@annthurium

Description

When wifi is disabled, Atom GitHub tab asks you to log in. It would be better to show an error message saying you have no connectivity.

Steps to Reproduce

  1. disable your wifi
  2. open a new atom window
  3. open the github tab

Expected behavior:

I'd see some kind of message that says "your internet is down" or whatever

Actual behavior:

The "login" button shows up instead.

screen shot 2018-10-05 at 4 58 20 pm

Reproduces how often:

100% of the time

Versions

Atom : 1.30.0-dev-a62462f66
Electron: 2.0.3
Chrome : 61.0.3163.100
Node : 8.9.3

Additional Information

Metadata

Metadata

Assignees

No one assigned

    Labels

    papercutSmall-scope issues and bugs we can use to backfill our sprint plans

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions