Git tries wrong branch when branch is named beginning with +

@TwoHorus commented on Dec 5, 2018, 2:32 PM UTC:

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Cannot push in atom, whilst cli pushing works. I suppose the Branch name starting with a Plus symbol is not parsed correctly.

Steps to Reproduce

1. Create Branch in gitlab
2. name it +Pages
3. switch branches in atom and push to the branch

Expected behavior: Atom Pushes to Branch

Actual behavior: Atom throws: error: src refspec Pages does not match any.
error: failed to push some refs to
'https://git.organisation.com/user/project

Reproduces how often: Every time

Version 1.33.0

Additional Information:

CMD ALT I reveals

Uncaught (in promise) GitError: git push origin +Pages in /Users/Admin/Documents/GitHub/project exited with code 1
stdout: 
stderr: error: src refspec Pages does not match any.
error: failed to push some refs to 'https://git.company.org/user/project.git'

    at new GitError (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2766914)
    at Promise (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2771732)
    at <anonymous>

This issue was moved by rsese from atom/atom#18544.

[JohnMeyerhoff]

Thanks.

[rsese]

Thanks for the report @TwoHorus! Can you share more detailed step-by-step instructions to reproduce? Based on a quick test, Atom doesn't seem to have issues if I create a branch called +Pages in Atom and then push that branch so I want to make sure I understand your repro steps.

[JohnMeyerhoff]

On my Macintosh Atom throws me an error, on my Windows machine my Atom throws no error but after commiting klicking "Push 1" results in an animation for 7 seconds and then it goes back to "Push 1".
GitHub desktop suggested i pull 7 files and then push 1. After that it tells me i can now push 2 files. Checking back atom now also says "Push 2". It might be my repository as neither GitHub desktop nor Atom are willing to push code to this branch. Git Bash tells me after "git push":
Everything up-to-date

Kind regards