Pull does not respect core.autocrlf

[winstliu]

Prerequisites

• Have you tried to reproduce the problem in Safe Mode? Yes
• Have you followed all applicable steps in the debugging guide? Yes
• Have you checked the FAQs on the message board for common solutions? Yes
• Have you checked that your issue isn't already filed? Yes

Description

github:pull appears to disregard the core.autocrlf setting. git config core.autocrlf returns false, yet when I pull LF files that have been changed on the remote, they are (wrongfully) converted to CRLF and (rightfully) marked as modified by the Tree View, but not by the github package. The same issue does not occur when executing git pull from the command line. This is on Windows 10 x64.

Steps to Reproduce

While I have not tried these steps, I am fairly confident that they should work:

1. On a Windows machine, ensure that git config core.autocrlf returns false (set it if necessary).
2. Push a file with LF line endings to GitHub.
3. Edit that file on some other computer and push the changes to GitHub.
4. Execute github:pull on the Windows computer.

Expected behavior: git reports 0 modified files.

Actual behavior: git reports 1 modified file, and the diff reveals that all line endings have been changed to CRLF.

Reproduces how often: 100%

Versions

Atom    : 1.35.0-dev-d036413c4
Electron: 2.0.14
Chrome  : 61.0.3163.100
Node    : 8.9.3

Windows 10 x64.

[winstliu]

This is also a problem when checking out branches.

[deyanx]

I see this was planned for January, but it's October now, and problem is still there... :)

Do you have some news about this?