Discarding changes in file clears commit message

[trogper]

Description

When reviewing changes to commit and deciding to revert line/hunk of code, the commit message is cleared, despite there being many more staged changes.
also present in safe mode

Steps to Reproduce

1. open git revisioned project
2. make changes in multiple files
3. stage one file
4. write a commit message
5. discard some other file

Expected behavior:

specified file is discarded
commit message is persisted

Actual behavior:

specified file is discarded
commit message is cleared

Reproduces how often:

every time

Versions

1.35.1 x64
Windows 10 1809

[rsese]

Thanks for the report! I can reproduce on macOS10.12.6 with 1.37.0-nightly32.

[wadethestealth]

@rsese can you still reproduce this? I can't on Windows 10 with 1.43.0-nightly12.

[trogper]

@rsese can you still reproduce this? I can't on Windows 10 with 1.43.0-nightly12.

still present on 1.41.0 x64, fresh install

[wadethestealth]

@trogper

Starting with 0 changes and 0 staged changes the workflow is the steps below?

1. Make changes in 2 files
2. Stage both files
3. write commit message
4. make a change in File A
5. view all staged changes
6. discard staged line in File a
7. ??? (I still see the commit message)

[trogper]

@wadethestealth
you have to discard the whole file

Starting with 0 changes and 0 staged changes the workflow is the steps below?

1. Make changes in 2 files
2. Stage one file
3. Write a commit message
4. Discard the whole unstaged file
5. Commit message is cleared

For me, the message gets cleared whenever I discard anything (line or file), no matter if I have anything staged.
By the way I can only discard unstaged changes

[wadethestealth]

Nvm I can reproduce I misunderstood discard for unstage. I can even reproduce without staging any changes.

[joallard]

I've been bitten many times by this, discarding my well-crafted commit message without undo. Not a trivial bug!