Flaky test: "timed out waiting until the list item for path symlink.txt (unstaged) appears‌"

[jasonrudolph]

We recently started seeing this test fail due to a timeout...

  1) integration: file patches‌
       with a file that used to be a symlink
         unstaged
           "before each" hook for "may stage the symlink deletion without the content addition":
     Error: async(9000ms): timed out waiting until the list item for path symlink.txt (unstaged) appears‌
      at Promise.resolve.catch.then.result (/Users/vsts/agent/2.150.3/work/1/s/node_modules/github/node_modules/test-until/index.js:56:25)
      at <anonymous>

Rebuilding sometimes resolves the failure.

---

Affected CI provider(s): Azure DevOps

Affected platform(s): macOS

Example commit experiencing flakiness: atom/atom@da8b1a1

Example failing build at that commit: https://github.visualstudio.com/Atom/_build/results?buildId=40526&view=logs&jobId=a5e52b91-c83f-5429-4a68-c246fc63a4f7&taskId=8b9bff53-2841-58c7-68fc-e30c30330fc3&lineStart=6967&lineEnd=6974&colStart=1&colEnd=21

Example passing build at that commit: https://github.visualstudio.com/Atom/_build/results?buildId=40564

[jasonrudolph]

@smashwilson Can you think of any recent changes that might cause this test to be flaky? Does this test depend on atom/notify at all?

[smashwilson]

It's likely caused by a difference in the watcher behavior, yeah. I can investigate 🔍

[jasonrudolph]

Another one: https://github.visualstudio.com/Atom/_build/results?buildId=40682&view=logs&jobId=a5e52b91-c83f-5429-4a68-c246fc63a4f7&taskId=8b9bff53-2841-58c7-68fc-e30c30330fc3&lineStart=6968&lineEnd=6975&colStart=1&colEnd=21