The Red Forbidden Circle over the commit button is unfriendly

[haacked]

I was trying to make a commit and noticed a red circle with a strike-through over the commit button. I can see that Atom really doesn't want me to create the commit. But I don't know why?

I realized later that I hadn't staged any changes yet. Oh! But I didn't draw the association with that and the red circle of forbidding.

As a general principle, disabling an action when it isn't immediately clear why that action is disabled is confusing. Instead, consider removing the ominous red circle and just let people click the Commit button and if nothing is staged, just show an error message stating that nothing has been staged (don't actually create the commit).

[simurai]

So we don't forget. Possible solutions mentioned in Slack:

• Keep the commit button clickable and show a notification.
• Disable the button and show a tooltip on hover.

Tooltip sounds friendlier.

[winstliu]

👍 on the tooltip; it's what Find and Replace does with the Replace All button.