Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Rendering in the Keybindings tab is extremely expensive #751

Open
@ssorallen

Description

@ssorallen

With a moderate amount of keybindings, filtering in the keybindings tab is pretty sluggish. Going from 1 character to 0 characters took 4s with the 'nuclide' package installed:

screen shot 2016-03-15 at 6 18 17 pm

When filtering, each keybinding row is appended to a <table> that is already in the DOM. A small change of rendering the rows to a documetFragment and then cloning the complete fragment into the table would be minimal work and have a big impact on filtering cost.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions