Store goalSetIds instead of goalSet to break loop

cdupuis · cdupuis · commit aac1d8ce9007 · 2021-06-03T21:49:49.000+02:00
[changelog:fixed]
diff --git a/lib/pack/goal-state/cancelGoals.ts b/lib/pack/goal-state/cancelGoals.ts
@@ -136,7 +136,7 @@ export function cancelGoalSetsCommand(sdm: SoftwareDeliveryMachine): CommandHand
                 let pgs = await pendingGoalSets(ci.context, sdm.configuration.name);
                 while (pgs.length > 0) {
                     for (const pg of pgs) {
-                        canceledGoalSets.push(pgs);
+                        canceledGoalSets.push(pg.goalSetId);
                         await cancelGoalSet(pg.goalSetId, ci.context);
                     }
                     pgs = (await pendingGoalSets(ci.context, sdm.configuration.name))

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ export function cancelGoalSetsCommand(sdm: SoftwareDeliveryMachine): CommandHand`
`136`	`136`	`let pgs = await pendingGoalSets(ci.context, sdm.configuration.name);`
`137`	`137`	`while (pgs.length > 0) {`
`138`	`138`	`for (const pg of pgs) {`
`139`		`- canceledGoalSets.push(pgs);`
	`139`	`+ canceledGoalSets.push(pg.goalSetId);`
`140`	`140`	`await cancelGoalSet(pg.goalSetId, ci.context);`
`141`	`141`	`}`
`142`	`142`	`pgs = (await pendingGoalSets(ci.context, sdm.configuration.name))`