fix: detect parenthesis independently from punctuation ending links

Author: Clément VÉRET

bsky-sdk/src/rich_text/detection.rs

@@ -70,8 +70,11 @@ pub fn detect_facets(text: &str) -> Vec<FacetWithoutResolution> {
             };
             let mut index = ByteSliceData { byte_end: m.end(), byte_start: m.start() };
             // strip ending punctuation
-            if (re_ending_punctuation.is_match(&uri)) || (uri.ends_with(')') && !uri.contains('('))
-            {
+            if re_ending_punctuation.is_match(&uri) {
+                uri.pop();
+                index.byte_end -= 1;
+            }
+            if uri.ends_with(')') && !uri.contains('(') {
                 uri.pop();
                 index.byte_end -= 1;
             }

bsky-sdk/src/rich_text/tests/detection.rs

@@ -249,6 +249,15 @@ async fn detect_facets_mentions_and_links() -> Result<()> {
                 (")", None),
             ],
         ),
+        (
+            "parenthentical with commas (https://foo.com), knowing that https://bar.com",
+            vec![
+                ("parenthentical with commas (", None),
+                ("https://foo.com", Some("https://foo.com")),
+                ("), knowing that ", None),
+                ("https://bar.com", Some("https://bar.com")),
+            ],
+        ),
         (
             "except for https://foo.com/thing_(cool)",
             vec![