Commit f19aec9
fix(codegen): Generate Collection impls for camelCase record NSIDs
`generate_modules` rebuilt the NSID from the snake_case'd file stem, so a
record whose NSID leaf is camelCase never matched its own schema and got no
`Collection` impl. Every record so far had a single-word leaf (`profile`,
`status`, `listitem`, ...), so this went unnoticed until
`app.bsky.actor.contentVisibilityDeclaration`.
The mismatch is not cosmetic: `KnownRecord` is built from schema ids and does
gain the variant, so downstream crates get a `KnownRecord` arm they cannot
satisfy because the `Collection` type does not exist.
Match on the snake_case'd NSID leaf instead, and use the schema's own id for
the `NSID` constant.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>1 parent ff18ee0 commit f19aec9
1 file changed
Lines changed: 7 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | | - | |
209 | 208 | | |
210 | 209 | | |
211 | 210 | | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
219 | 217 | | |
220 | | - | |
| 218 | + | |
221 | 219 | | |
222 | 220 | | |
223 | 221 | | |
| |||
0 commit comments